From: Peter Mamonov <pmamonov@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH] Pass barebox version to kernel
Date: Mon, 26 Feb 2018 13:12:02 +0300 [thread overview]
Message-ID: <20180226101201.k7ync5dx3yaynslg@localhost.localdomain> (raw)
In-Reply-To: <20180226082349.31568-1-s.hauer@pengutronix.de>
Hi, Sasha,
On Mon, Feb 26, 2018 at 09:23:49AM +0100, Sascha Hauer wrote:
> When userspace is interested in the barebox version it has currently no
> way of reliably reading it. Add it to the kernel command line as it's an
> established way to pass information from the bootloader to the kernel.
> If CONFIG_FLEXIBLE_BOOTARGS is enabled then the barebox version is
> passed in the "bootloader.version=" variable.
Some time ago we solved a similar problem: a number of parameters including
barebox version, MAC address (which may be random due to the lack of a NIC
EEPROM) and some vendor specific parameters are passed to the kernel via DTB.
A dedicated command was implemented which can either patch the existing DTB or
generate an overlay DTB. In the latter case the overlay DTB is passed to the
kernel with the help of a new `bootm` option. Of course the latter approach
requires support on the kernel side.
Are you interested in adopting this code into barebox?
Regards,
Peter
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> common/globalvar.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/common/globalvar.c b/common/globalvar.c
> index b9bfce7dac..eff4cbc72e 100644
> --- a/common/globalvar.c
> +++ b/common/globalvar.c
> @@ -571,6 +571,8 @@ int globalvar_add_simple_ip(const char *name, IPaddr_t *ip)
> return 0;
> }
>
> +static char *kernel_arg_bootloader_version;
> +
> static int globalvar_init(void)
> {
> register_device(&global_device);
> @@ -580,6 +582,13 @@ static int globalvar_init(void)
>
> globalvar_add_simple("version", UTS_RELEASE);
>
> + if (IS_ENABLED(CONFIG_FLEXIBLE_BOOTARGS)) {
> + kernel_arg_bootloader_version = basprintf("bootloader.version=barebox-%s",
> + UTS_RELEASE);
> + globalvar_add_simple_string("linux.bootargs.bootloader.version",
> + &kernel_arg_bootloader_version);
> + }
> +
> return 0;
> }
> pure_initcall(globalvar_init);
> --
> 2.16.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2018-02-26 10:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-26 8:23 Sascha Hauer
2018-02-26 10:12 ` Peter Mamonov [this message]
2018-02-27 8:34 ` Sascha Hauer
2018-02-27 19:43 ` Peter Mamonov
2018-02-28 7:34 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180226101201.k7ync5dx3yaynslg@localhost.localdomain \
--to=pmamonov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox