From: Sascha Hauer <s.hauer@pengutronix.de>
To: Oleksij Rempel <linux@rempel-privat.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v1 1/2] watchdog: ar9344-wdt: disable watchdog in probe
Date: Thu, 1 Mar 2018 10:03:32 +0100 [thread overview]
Message-ID: <20180301090332.g2nq3rzcxvtsmgx2@pengutronix.de> (raw)
In-Reply-To: <20180228172206.12823-1-linux@rempel-privat.de>
On Wed, Feb 28, 2018 at 06:22:05PM +0100, Oleksij Rempel wrote:
> This should avoid of triggering reset if we boot barebox from
> barebox.
>
> Signed-off-by: Oleksij Rempel <linux@rempel-privat.de>
> ---
> drivers/watchdog/ar9344_wdt.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/watchdog/ar9344_wdt.c b/drivers/watchdog/ar9344_wdt.c
> index d570cb40f..b61786b1b 100644
> --- a/drivers/watchdog/ar9344_wdt.c
> +++ b/drivers/watchdog/ar9344_wdt.c
> @@ -101,6 +101,8 @@ static int ar9344_wdt_probe(struct device_d *dev)
> dev->priv = priv;
>
> ar9344_watchdog_detect_reset_source(priv);
> + /* disable watchdog on probe */
> + iowrite32be(0, priv->base + AR9344_WD_REG_CTRL);
Do we really want this? I would assume that if the watchdog is enabled
here, then it is enabled on purpose and disabling it just bypasses this
purpose.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2018-03-01 9:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 17:22 Oleksij Rempel
2018-02-28 17:22 ` [PATCH v1 2/2] MIPS: dts: enable heartbeat led for ar9331-dptechnics-dpt-module Oleksij Rempel
2018-03-01 9:04 ` Sascha Hauer
2018-03-01 9:03 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180301090332.g2nq3rzcxvtsmgx2@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=linux@rempel-privat.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox