From: Oleksij Rempel <o.rempel@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Oleksij Rempel <o.rempel@pengutronix.de>
Subject: [PATCH v1 6/6] watchdog: add watchdog poller
Date: Thu, 8 Mar 2018 12:05:15 +0100 [thread overview]
Message-ID: <20180308110515.29574-6-o.rempel@pengutronix.de> (raw)
In-Reply-To: <20180308110515.29574-1-o.rempel@pengutronix.de>
In some cases it is practical to supervise as match as possible of
barebox execution with watchdog (or multiple watchdogs). This
patch provide async poller for watchdog core framework which can
be enabled by user and store this configuration to nv.
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
drivers/watchdog/wd_core.c | 54 ++++++++++++++++++++++++++++++++++++++++------
include/watchdog.h | 4 ++++
2 files changed, 52 insertions(+), 6 deletions(-)
diff --git a/drivers/watchdog/wd_core.c b/drivers/watchdog/wd_core.c
index 3162dd59c..6f1cadaf8 100644
--- a/drivers/watchdog/wd_core.c
+++ b/drivers/watchdog/wd_core.c
@@ -31,6 +31,16 @@ static const char *watchdog_name(struct watchdog *wd)
return "unknown";
}
+static int _watchdog_set_timeout(struct watchdog *wd, unsigned timeout)
+{
+ if (timeout > wd->timeout_max)
+ return -EINVAL;
+
+ pr_debug("setting timeout on %s to %ds\n", watchdog_name(wd), timeout);
+
+ return wd->set_timeout(wd, timeout);
+}
+
static int watchdog_set_cur(struct param_d *param, void *priv)
{
struct watchdog *wd = priv;
@@ -41,6 +51,37 @@ static int watchdog_set_cur(struct param_d *param, void *priv)
return 0;
}
+static void watchdog_poller_cb(void *priv);
+
+static void watchdog_poller_start(struct watchdog *wd)
+{
+ _watchdog_set_timeout(wd, wd->timeout_cur);
+ poller_call_async(&wd->poller, 500 * MSECOND,
+ watchdog_poller_cb, wd);
+
+}
+
+static void watchdog_poller_cb(void *priv)
+{
+ struct watchdog *wd = priv;
+
+ if (wd->poller_enable)
+ watchdog_poller_start(wd);
+}
+
+static int watchdog_set_poller(struct param_d *param, void *priv)
+{
+ struct watchdog *wd = priv;
+
+
+ if (wd->poller_enable)
+ watchdog_poller_start(wd);
+ else
+ poller_async_cancel(&wd->poller);
+
+ return 0;
+}
+
int watchdog_register(struct watchdog *wd)
{
@@ -63,6 +104,10 @@ int watchdog_register(struct watchdog *wd)
dev_add_param_uint32(&wd->dev, "timeout_cur", watchdog_set_cur, NULL,
&wd->timeout_cur, "%u", wd);
+ poller_async_register(&wd->poller);
+ dev_add_param_bool(&wd->dev, "poller_enable", watchdog_set_poller, NULL,
+ &wd->poller_enable, wd);
+
list_add_tail(&wd->list, &watchdog_list);
pr_debug("registering watchdog %s with priority %d\n", watchdog_name(wd),
@@ -74,6 +119,8 @@ EXPORT_SYMBOL(watchdog_register);
int watchdog_deregister(struct watchdog *wd)
{
+ poller_async_cancel(&wd->poller);
+ poller_async_unregister(&wd->poller);
unregister_device(&wd->dev);
list_del(&wd->list);
@@ -109,12 +156,7 @@ int watchdog_set_timeout(unsigned timeout)
if (!wd)
return -ENODEV;
- if (timeout > wd->timeout_max)
- return -EINVAL;
-
- pr_debug("setting timeout on %s to %ds\n", watchdog_name(wd), timeout);
-
- return wd->set_timeout(wd, timeout);
+ return _watchdog_set_timeout(wd, timeout);
}
EXPORT_SYMBOL(watchdog_set_timeout);
diff --git a/include/watchdog.h b/include/watchdog.h
index 2f1874c19..0db4263a3 100644
--- a/include/watchdog.h
+++ b/include/watchdog.h
@@ -13,6 +13,8 @@
#ifndef INCLUDE_WATCHDOG_H
# define INCLUDE_WATCHDOG_H
+#include <poller.h>
+
struct watchdog {
int (*set_timeout)(struct watchdog *, unsigned);
const char *name;
@@ -21,6 +23,8 @@ struct watchdog {
unsigned int priority;
unsigned int timeout_max;
unsigned int timeout_cur;
+ unsigned int poller_enable;
+ struct poller_async poller;
struct list_head list;
};
--
2.16.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2018-03-08 11:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-08 11:05 [PATCH v1 1/6] watchdog: rename dev to hwdev Oleksij Rempel
2018-03-08 11:05 ` [PATCH v1 2/6] watchdog: move max timeout test in to wd_core Oleksij Rempel
2018-03-08 11:05 ` [PATCH v1 3/6] watchdog: register watchdog virtual device with short name wdog Oleksij Rempel
2018-03-12 10:35 ` Sascha Hauer
2018-03-08 11:05 ` [PATCH v1 4/6] watchdog: set some reasonable timeout_max value if no other is available Oleksij Rempel
2018-03-12 10:37 ` Sascha Hauer
2018-03-08 11:05 ` [PATCH v1 5/6] watchdog: provide timeout_cur value Oleksij Rempel
2018-03-08 11:05 ` Oleksij Rempel [this message]
2018-03-08 13:49 ` [PATCH v1 6/6] watchdog: add watchdog poller Jan Lübbe
2018-03-08 14:16 ` Oleksij Rempel
2018-03-08 15:33 ` Jan Lübbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180308110515.29574-6-o.rempel@pengutronix.de \
--to=o.rempel@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox