mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Andrey Gusakov <andrey.gusakov@cogentembedded.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] video: tc358767: register aux i2c bus after validating link
Date: Mon, 12 Mar 2018 11:29:55 +0100	[thread overview]
Message-ID: <20180312102955.a55fq5ymrqcg452g@pengutronix.de> (raw)
In-Reply-To: <1520259593-21311-1-git-send-email-andrey.gusakov@cogentembedded.com>

On Mon, Mar 05, 2018 at 05:19:53PM +0300, Andrey Gusakov wrote:
> Register AUX i2c adapter only if AUX link is functional. This
> should avoid possible hung during tc358767 probe when no display
> connected.
> 
> Signed-off-by: Andrey Gusakov <andrey.gusakov@cogentembedded.com>
> ---
>  drivers/video/tc358767.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Applied, thanks

Sascha

> 
> diff --git a/drivers/video/tc358767.c b/drivers/video/tc358767.c
> index f9ca06c..5ad5cb4 100644
> --- a/drivers/video/tc358767.c
> +++ b/drivers/video/tc358767.c
> @@ -1404,6 +1404,10 @@ static int tc_probe(struct device_d *dev)
>  	if (ret)
>  		goto err;
>  
> +	ret = tc_get_display_props(tc);
> +	if (ret)
> +		goto err;
> +
>  	/* Register DP AUX channel */
>  	tc->adapter.master_xfer = tc_aux_i2c_xfer;
>  	tc->adapter.nr = -1; /* any free */
> @@ -1416,10 +1420,6 @@ static int tc_probe(struct device_d *dev)
>  		goto err;
>  	}
>  
> -	ret = tc_get_display_props(tc);
> -	if (ret)
> -		goto err;
> -
>  	/* add vlp */
>  	tc->vpl.node = dev->device_node;
>  	tc->vpl.ioctl = tc_ioctl;
> -- 
> 1.9.1
> 
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2018-03-12 10:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-05 14:19 Andrey Gusakov
2018-03-12 10:29 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180312102955.a55fq5ymrqcg452g@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=andrey.gusakov@cogentembedded.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox