[PATCH] of: demote "no ranges" message to debug level

[PATCH] of: demote "no ranges" message to debug level

[Lucas Stach]

There are valid cases where there is no way to translate a OF node to
a MMIO address via ranges, so do the same as the Linux kernel and don't
print an error message in that case, but make it available as a debug
message.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 drivers/of/address.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/of/address.c b/drivers/of/address.c
index 8018d78bcbd8..14db08041725 100644
--- a/drivers/of/address.c
+++ b/drivers/of/address.c
@@ -314,7 +314,7 @@ static int of_translate_one(struct device_node *parent, struct of_bus *bus,
 	ranges = of_get_property(parent, rprop, &rlen);
 #if !defined(CONFIG_PPC)
 	if (ranges == NULL) {
-		pr_err("OF: no ranges; cannot translate\n");
+		pr_debug("OF: no ranges; cannot translate\n");
 		return 1;
 	}
 #endif /* !defined(CONFIG_PPC) */
-- 
2.16.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] of: demote "no ranges" message to debug level

[Sascha Hauer]

On Fri, Mar 16, 2018 at 03:56:58PM +0100, Lucas Stach wrote:
> There are valid cases where there is no way to translate a OF node to
> a MMIO address via ranges, so do the same as the Linux kernel and don't
> print an error message in that case, but make it available as a debug
> message.
> 
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
>  drivers/of/address.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks

Sascha

> 
> diff --git a/drivers/of/address.c b/drivers/of/address.c
> index 8018d78bcbd8..14db08041725 100644
> --- a/drivers/of/address.c
> +++ b/drivers/of/address.c
> @@ -314,7 +314,7 @@ static int of_translate_one(struct device_node *parent, struct of_bus *bus,
>  	ranges = of_get_property(parent, rprop, &rlen);
>  #if !defined(CONFIG_PPC)
>  	if (ranges == NULL) {
> -		pr_err("OF: no ranges; cannot translate\n");
> +		pr_debug("OF: no ranges; cannot translate\n");
>  		return 1;
>  	}
>  #endif /* !defined(CONFIG_PPC) */
> -- 
> 2.16.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox