From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Gaël PORTAY" <gael.portay@savoirfairelinux.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] fs: check pointer returned by get_fsdevice_by_path before dereferencing
Date: Mon, 19 Mar 2018 09:36:29 +0100 [thread overview]
Message-ID: <20180319083629.kxjdc4jnd35prif2@pengutronix.de> (raw)
In-Reply-To: <20180318222236.28296-1-gael.portay@savoirfairelinux.com>
Hi Gaël,
On Sun, Mar 18, 2018 at 06:22:36PM -0400, Gaël PORTAY wrote:
> In __canonicalize_path() we dereference the pointer returned by
> get_fsdevice_by_path() without checking if the pointer is NULL or not.
> When the pointer is NULL it leads to an Ooops.
>
> Ooops, address error on load or ifetch!
>
> $ 0 : 00000000 00000001 a0000026 a0811c10
> $ 4 : a0402e60 a0402e48 a0811c00 a0402e58
> $ 8 : 00000001 00000000 0000005a 00000023
> $12 : 00000000 00000002 00601021 00000000
> $16 : a0402e60 a0402e50 a0402e39 a0810000
> $20 : a0402e38 a0811420 a0811424 00000000
> $24 : 00000000 a080de10
> $28 : 87f87d40 a03ffa68 a0810000 a080ce30
> Hi : 00000002
> Lo : 00000000
> epc : a080ce34
> ra : a080ce30
> Status: 00000006
> Cause : 40008010
> Config: 80040483
>
> ### ERROR ### Please RESET the board ###
>
> Fixes: d79a81736 fs: Don't bother filesystems without link support with additional stat() calls
>
> Signed-off-by: Gaël PORTAY <gael.portay@savoirfairelinux.com>
> ---
> fs/fs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
I wonder though what calls into the filesystem layer before / is
mounted in your case.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2018-03-19 8:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-18 22:22 Gaël PORTAY
2018-03-19 8:36 ` Sascha Hauer [this message]
2018-03-19 9:06 ` Gaël PORTAY
2018-03-27 7:17 ` Antony Pavlov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180319083629.kxjdc4jnd35prif2@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=gael.portay@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox