mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Barebox List <barebox@lists.infradead.org>
Subject: [PATCH 09/14] net: fec_imx: Use dma mapping functions
Date: Mon, 19 Mar 2018 10:11:41 +0100	[thread overview]
Message-ID: <20180319091146.4112-10-s.hauer@pengutronix.de> (raw)
In-Reply-To: <20180319091146.4112-1-s.hauer@pengutronix.de>

Rather than doing DMA on the input buffer address get a proper DMA
address from the mapping functions.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 drivers/net/fec_imx.c | 15 +++++++++------
 drivers/net/fec_imx.h |  1 +
 2 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/drivers/net/fec_imx.c b/drivers/net/fec_imx.c
index 33599dd826..0ca5940821 100644
--- a/drivers/net/fec_imx.c
+++ b/drivers/net/fec_imx.c
@@ -453,6 +453,7 @@ static int fec_send(struct eth_device *dev, void *eth_data, int data_length)
 {
 	unsigned int status;
 	uint64_t tmo;
+	dma_addr_t dma;
 
 	/*
 	 * This routine transmits one frame.  This routine only accepts
@@ -466,7 +467,7 @@ static int fec_send(struct eth_device *dev, void *eth_data, int data_length)
 		return -1;
 	}
 
-	if ((uint32_t)eth_data & (DB_DATA_ALIGNMENT-1))
+	if ((unsigned long)eth_data & (DB_DATA_ALIGNMENT - 1))
 		dev_warn(&dev->dev, "Transmit data not aligned: %p!\n", eth_data);
 
 	/*
@@ -479,10 +480,12 @@ static int fec_send(struct eth_device *dev, void *eth_data, int data_length)
 
 	writew(data_length, &fec->tbd_base[fec->tbd_index].data_length);
 
-	writel((uint32_t)(eth_data), &fec->tbd_base[fec->tbd_index].data_pointer);
+	dma = dma_map_single(fec->dev, eth_data, data_length, DMA_TO_DEVICE);
+	if (dma_mapping_error(fec->dev, dma))
+		return -EIO;
+
+	writel((uint32_t)(dma), &fec->tbd_base[fec->tbd_index].data_pointer);
 
-	dma_sync_single_for_device((unsigned long)eth_data, data_length,
-				   DMA_TO_DEVICE);
 	/*
 	 * update BD's status now
 	 * This block:
@@ -505,8 +508,7 @@ static int fec_send(struct eth_device *dev, void *eth_data, int data_length)
 			break;
 		}
 	}
-	dma_sync_single_for_cpu((unsigned long)eth_data, data_length,
-				DMA_TO_DEVICE);
+	dma_unmap_single(fec->dev, dma, data_length, DMA_TO_DEVICE);
 
 	/* for next transmission use the other buffer */
 	if (fec->tbd_index)
@@ -748,6 +750,7 @@ static int fec_probe(struct device_d *dev)
 
 	fec = xzalloc(sizeof(*fec));
 	fec->type = type;
+	fec->dev = dev;
 	edev = &fec->edev;
 	dev->priv = fec;
 	edev->priv = fec;
diff --git a/drivers/net/fec_imx.h b/drivers/net/fec_imx.h
index 561de0890b..e3f60dd66a 100644
--- a/drivers/net/fec_imx.h
+++ b/drivers/net/fec_imx.h
@@ -149,6 +149,7 @@ enum fec_opt_clock {
  */
 struct fec_priv {
 	struct eth_device edev;
+	struct device_d *dev;
 	void __iomem *regs;
 	struct buffer_descriptor __iomem *rbd_base;	/* RBD ring                  */
 	int rbd_index;				/* next receive BD to read   */
-- 
2.16.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2018-03-19  9:12 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-19  9:11 [PATCH 00/14] ARM: i.MX8MQ and EVK support Sascha Hauer
2018-03-19  9:11 ` [PATCH 01/14] ARM: i.MX: xload: Fix compiler warning Sascha Hauer
2018-03-19  9:11 ` [PATCH 02/14] ARM: i.MX: compile arm32 specific errata only for CPU32 Sascha Hauer
2018-03-19  9:11 ` [PATCH 03/14] ARM: Add i.MX8 support Sascha Hauer
2018-03-19  9:11 ` [PATCH 04/14] aarch64: Add i.MX8 debug UART support Sascha Hauer
2018-03-19  9:11 ` [PATCH 05/14] Include our own include/dt-bindings Sascha Hauer
2018-03-19  9:11 ` [PATCH 06/14] ARM: i.MX8: Add i.MX8mq EVK support Sascha Hauer
2018-03-19  9:11 ` [PATCH 07/14] mci: imx-esdhc: use dma mapping functions Sascha Hauer
2018-03-19  9:11 ` [PATCH 08/14] net: fec_imx: remove unnecessary DMA sync ops Sascha Hauer
2018-03-19  9:11 ` Sascha Hauer [this message]
2018-03-19  9:11 ` [PATCH 10/14] clock: Add i.MX8MQ clock driver Sascha Hauer
2018-03-19  9:11 ` [PATCH 11/14] serial: i.MX: Add i.MX8 support Sascha Hauer
2018-03-19  9:11 ` [PATCH 12/14] mmc: i.MX esdhc: " Sascha Hauer
2018-03-19  9:11 ` [PATCH 13/14] gpio: i.MX: Add i.MX8mq support Sascha Hauer
2018-03-19  9:11 ` [PATCH 14/14] ARM: i.MX: ocotp: Add i.MX8MQ support Sascha Hauer
2018-03-21  5:41 ` [PATCH 00/14] ARM: i.MX8MQ and EVK support Andrey Smirnov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180319091146.4112-10-s.hauer@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox