* [PATCH] aiodev: Constify 'unit' in 'struct aiodev'
@ 2018-03-26 13:14 Andrey Smirnov
2018-04-03 7:08 ` Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Andrey Smirnov @ 2018-03-26 13:14 UTC (permalink / raw)
To: barebox; +Cc: Andrey Smirnov
The way it is currently used, there's no reason for 'uint' field to be
mutable, so constify it in order to allow 'aiodev' drivers to pass
sting literals in that field.
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
include/aiodev.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/aiodev.h b/include/aiodev.h
index 0d4f7a294..5e38b4fab 100644
--- a/include/aiodev.h
+++ b/include/aiodev.h
@@ -23,7 +23,7 @@
struct aiodevice;
struct aiochannel {
int index;
- char *unit;
+ const char *unit;
struct aiodevice *aiodev;
int value;
--
2.14.3
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] aiodev: Constify 'unit' in 'struct aiodev'
2018-03-26 13:14 [PATCH] aiodev: Constify 'unit' in 'struct aiodev' Andrey Smirnov
@ 2018-04-03 7:08 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2018-04-03 7:08 UTC (permalink / raw)
To: Andrey Smirnov; +Cc: barebox
On Mon, Mar 26, 2018 at 06:14:45AM -0700, Andrey Smirnov wrote:
> The way it is currently used, there's no reason for 'uint' field to be
> mutable, so constify it in order to allow 'aiodev' drivers to pass
> sting literals in that field.
>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
> include/aiodev.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks
Sascha
>
> diff --git a/include/aiodev.h b/include/aiodev.h
> index 0d4f7a294..5e38b4fab 100644
> --- a/include/aiodev.h
> +++ b/include/aiodev.h
> @@ -23,7 +23,7 @@
> struct aiodevice;
> struct aiochannel {
> int index;
> - char *unit;
> + const char *unit;
> struct aiodevice *aiodev;
>
> int value;
> --
> 2.14.3
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-04-03 7:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-26 13:14 [PATCH] aiodev: Constify 'unit' in 'struct aiodev' Andrey Smirnov
2018-04-03 7:08 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox