[PATCH] of: partition: fix typo when writing #address-cells

[PATCH] of: partition: fix typo when writing #address-cells

[Philipp Zabel]

On > 4 GiB eMMC devices, barebox writes a 32-bit address and a 64-bit
size into the partition reg property, because #address-cells is
accidentally written as '#addres-cells'. This causes a fallback to
32-bit address size. Fix the typo and thereby of_partition_fixup for
64-bit partitions.

Fixes: a2fa18f9f483 ("mtd: of: Make used partition binding configurable")
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
 drivers/of/partition.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/of/partition.c b/drivers/of/partition.c
index 6f9651a9e4..aa6e601b7f 100644
--- a/drivers/of/partition.c
+++ b/drivers/of/partition.c
@@ -190,7 +190,7 @@ static int of_partition_fixup(struct device_node *root, void *ctx)
 	if (ret)
 		return ret;
 
-	of_property_write_u32(partnode, "#addres-cells", n_cells);
+	of_property_write_u32(partnode, "#address-cells", n_cells);
 	if (ret)
 		return ret;
 
-- 
2.16.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] of: partition: fix typo when writing #address-cells

[Sascha Hauer]

On Mon, Mar 26, 2018 at 04:25:56PM +0200, Philipp Zabel wrote:
> On > 4 GiB eMMC devices, barebox writes a 32-bit address and a 64-bit
> size into the partition reg property, because #address-cells is
> accidentally written as '#addres-cells'. This causes a fallback to
> 32-bit address size. Fix the typo and thereby of_partition_fixup for
> 64-bit partitions.
> 
> Fixes: a2fa18f9f483 ("mtd: of: Make used partition binding configurable")
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
>  drivers/of/partition.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks

Sascha

> 
> diff --git a/drivers/of/partition.c b/drivers/of/partition.c
> index 6f9651a9e4..aa6e601b7f 100644
> --- a/drivers/of/partition.c
> +++ b/drivers/of/partition.c
> @@ -190,7 +190,7 @@ static int of_partition_fixup(struct device_node *root, void *ctx)
>  	if (ret)
>  		return ret;
>  
> -	of_property_write_u32(partnode, "#addres-cells", n_cells);
> +	of_property_write_u32(partnode, "#address-cells", n_cells);
>  	if (ret)
>  		return ret;
>  
> -- 
> 2.16.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox