From: Antony Pavlov <antonynpavlov@gmail.com>
To: "Gaël PORTAY" <gael.portay@savoirfairelinux.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] fs: check pointer returned by get_fsdevice_by_path before dereferencing
Date: Tue, 27 Mar 2018 10:17:16 +0300 [thread overview]
Message-ID: <20180327101716.697486501ccea51c7b98644a@gmail.com> (raw)
In-Reply-To: <20180318222236.28296-1-gael.portay@savoirfairelinux.com>
On Sun, 18 Mar 2018 18:22:36 -0400
Gaël PORTAY <gael.portay@savoirfairelinux.com> wrote:
> In __canonicalize_path() we dereference the pointer returned by
> get_fsdevice_by_path() without checking if the pointer is NULL or not.
> When the pointer is NULL it leads to an Ooops.
>
> Ooops, address error on load or ifetch!
>
> $ 0 : 00000000 00000001 a0000026 a0811c10
> $ 4 : a0402e60 a0402e48 a0811c00 a0402e58
> $ 8 : 00000001 00000000 0000005a 00000023
> $12 : 00000000 00000002 00601021 00000000
> $16 : a0402e60 a0402e50 a0402e39 a0810000
> $20 : a0402e38 a0811420 a0811424 00000000
> $24 : 00000000 a080de10
> $28 : 87f87d40 a03ffa68 a0810000 a080ce30
> Hi : 00000002
> Lo : 00000000
> epc : a080ce34
Salut Gaël!
It looks like you use MIPS board.
Your epc == 0xa080ce34 is inside KSEG1 region (uncached memory).
May be there is no cache support in current barebox for your CPU.
Which CPU core you use?
Très cordialement,
Antony Pavlov
> ra : a080ce30
> Status: 00000006
> Cause : 40008010
> Config: 80040483
>
> ### ERROR ### Please RESET the board ###
>
> Fixes: d79a81736 fs: Don't bother filesystems without link support with additional stat() calls
>
> Signed-off-by: Gaël PORTAY <gael.portay@savoirfairelinux.com>
> ---
> fs/fs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/fs.c b/fs/fs.c
> index 88f0b1478..5135112c8 100644
> --- a/fs/fs.c
> +++ b/fs/fs.c
> @@ -191,7 +191,7 @@ static char *__canonicalize_path(const char *_pathname, int level)
> * with an additional stat() call.
> */
> fsdev = get_fsdevice_by_path(outpath);
> - if (!fsdev->driver->readlink)
> + if (!fsdev || !fsdev->driver->readlink)
> continue;
>
> ret = __lstat(outpath, &s);
> --
> 2.16.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2018-03-27 7:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-18 22:22 Gaël PORTAY
2018-03-19 8:36 ` Sascha Hauer
2018-03-19 9:06 ` Gaël PORTAY
2018-03-27 7:17 ` Antony Pavlov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180327101716.697486501ccea51c7b98644a@gmail.com \
--to=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=gael.portay@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox