From: Sascha Hauer <s.hauer@pengutronix.de>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] of: partition: fix typo when writing #address-cells
Date: Thu, 29 Mar 2018 09:02:05 +0200 [thread overview]
Message-ID: <20180329070205.dfiivafh5xghupvs@pengutronix.de> (raw)
In-Reply-To: <20180326142556.27727-1-p.zabel@pengutronix.de>
On Mon, Mar 26, 2018 at 04:25:56PM +0200, Philipp Zabel wrote:
> On > 4 GiB eMMC devices, barebox writes a 32-bit address and a 64-bit
> size into the partition reg property, because #address-cells is
> accidentally written as '#addres-cells'. This causes a fallback to
> 32-bit address size. Fix the typo and thereby of_partition_fixup for
> 64-bit partitions.
>
> Fixes: a2fa18f9f483 ("mtd: of: Make used partition binding configurable")
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
> drivers/of/partition.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks
Sascha
>
> diff --git a/drivers/of/partition.c b/drivers/of/partition.c
> index 6f9651a9e4..aa6e601b7f 100644
> --- a/drivers/of/partition.c
> +++ b/drivers/of/partition.c
> @@ -190,7 +190,7 @@ static int of_partition_fixup(struct device_node *root, void *ctx)
> if (ret)
> return ret;
>
> - of_property_write_u32(partnode, "#addres-cells", n_cells);
> + of_property_write_u32(partnode, "#address-cells", n_cells);
> if (ret)
> return ret;
>
> --
> 2.16.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2018-03-29 7:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-26 14:25 Philipp Zabel
2018-03-29 7:02 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180329070205.dfiivafh5xghupvs@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox