mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH 1/2] i.MX: vf610-twr: Print '>' when DEBUG_LL is enabled
@ 2018-04-10 23:40 Andrey Smirnov
  2018-04-10 23:40 ` [PATCH 2/2] i.MX: vf610-twr: Convert to use vf610_setup_pad() Andrey Smirnov
  2018-04-11  8:44 ` [PATCH 1/2] i.MX: vf610-twr: Print '>' when DEBUG_LL is enabled Sascha Hauer
  0 siblings, 2 replies; 3+ messages in thread
From: Andrey Smirnov @ 2018-04-10 23:40 UTC (permalink / raw)
  To: barebox; +Cc: Andrey Smirnov

Majority of others boards prints '>' as soon as DEBUG_LL related
configuration is done, so do so for VF610-TWR as well.

Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
 arch/arm/boards/freescale-vf610-twr/lowlevel.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/boards/freescale-vf610-twr/lowlevel.c b/arch/arm/boards/freescale-vf610-twr/lowlevel.c
index a043dd421..65956fdd2 100644
--- a/arch/arm/boards/freescale-vf610-twr/lowlevel.c
+++ b/arch/arm/boards/freescale-vf610-twr/lowlevel.c
@@ -22,6 +22,8 @@ static inline void setup_uart(void)
 	writel(0, iomuxbase + 0x0380);
 
 	vf610_uart_setup_ll();
+
+	putc_ll('>');
 }
 
 extern char __dtb_vf610_twr_start[];
-- 
2.14.3


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 2/2] i.MX: vf610-twr: Convert to use vf610_setup_pad()
  2018-04-10 23:40 [PATCH 1/2] i.MX: vf610-twr: Print '>' when DEBUG_LL is enabled Andrey Smirnov
@ 2018-04-10 23:40 ` Andrey Smirnov
  2018-04-11  8:44 ` [PATCH 1/2] i.MX: vf610-twr: Print '>' when DEBUG_LL is enabled Sascha Hauer
  1 sibling, 0 replies; 3+ messages in thread
From: Andrey Smirnov @ 2018-04-10 23:40 UTC (permalink / raw)
  To: barebox; +Cc: Andrey Smirnov

Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
 arch/arm/boards/freescale-vf610-twr/lowlevel.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/arch/arm/boards/freescale-vf610-twr/lowlevel.c b/arch/arm/boards/freescale-vf610-twr/lowlevel.c
index 65956fdd2..8fec9f4b9 100644
--- a/arch/arm/boards/freescale-vf610-twr/lowlevel.c
+++ b/arch/arm/boards/freescale-vf610-twr/lowlevel.c
@@ -14,13 +14,7 @@ static inline void setup_uart(void)
 	void __iomem *iomuxbase = IOMEM(VF610_IOMUXC_BASE_ADDR);
 
 	vf610_ungate_all_peripherals();
-
-	/*
-	 * VF610_PAD_PTB4__UART1_TX
-	 */
-	writel(VF610_UART_PAD_CTRL | (2 << 20), iomuxbase + 0x0068);
-	writel(0, iomuxbase + 0x0380);
-
+	vf610_setup_pad(iomuxbase, VF610_PAD_PTB4__UART1_TX);
 	vf610_uart_setup_ll();
 
 	putc_ll('>');
-- 
2.14.3


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] i.MX: vf610-twr: Print '>' when DEBUG_LL is enabled
  2018-04-10 23:40 [PATCH 1/2] i.MX: vf610-twr: Print '>' when DEBUG_LL is enabled Andrey Smirnov
  2018-04-10 23:40 ` [PATCH 2/2] i.MX: vf610-twr: Convert to use vf610_setup_pad() Andrey Smirnov
@ 2018-04-11  8:44 ` Sascha Hauer
  1 sibling, 0 replies; 3+ messages in thread
From: Sascha Hauer @ 2018-04-11  8:44 UTC (permalink / raw)
  To: Andrey Smirnov; +Cc: barebox

On Tue, Apr 10, 2018 at 04:40:37PM -0700, Andrey Smirnov wrote:
> Majority of others boards prints '>' as soon as DEBUG_LL related
> configuration is done, so do so for VF610-TWR as well.
> 
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
>  arch/arm/boards/freescale-vf610-twr/lowlevel.c | 2 ++
>  1 file changed, 2 insertions(+)

Applied, thanks

Sascha

> 
> diff --git a/arch/arm/boards/freescale-vf610-twr/lowlevel.c b/arch/arm/boards/freescale-vf610-twr/lowlevel.c
> index a043dd421..65956fdd2 100644
> --- a/arch/arm/boards/freescale-vf610-twr/lowlevel.c
> +++ b/arch/arm/boards/freescale-vf610-twr/lowlevel.c
> @@ -22,6 +22,8 @@ static inline void setup_uart(void)
>  	writel(0, iomuxbase + 0x0380);
>  
>  	vf610_uart_setup_ll();
> +
> +	putc_ll('>');
>  }
>  
>  extern char __dtb_vf610_twr_start[];
> -- 
> 2.14.3
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-04-11  8:44 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-10 23:40 [PATCH 1/2] i.MX: vf610-twr: Print '>' when DEBUG_LL is enabled Andrey Smirnov
2018-04-10 23:40 ` [PATCH 2/2] i.MX: vf610-twr: Convert to use vf610_setup_pad() Andrey Smirnov
2018-04-11  8:44 ` [PATCH 1/2] i.MX: vf610-twr: Print '>' when DEBUG_LL is enabled Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox