From: Sascha Hauer <s.hauer@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] commands: i2c_write: enable reg == 0 too
Date: Tue, 17 Apr 2018 09:25:22 +0200 [thread overview]
Message-ID: <20180417072522.u3tvxjph5vehw4bt@pengutronix.de> (raw)
In-Reply-To: <20180417035829.11841-1-antonynpavlov@gmail.com>
On Tue, Apr 17, 2018 at 06:58:29AM +0300, Antony Pavlov wrote:
> This commit fixes the mistake introduced in the commit 34fadb685905
> ('commands: i2c_write: enable raw write to address').
> The intended behaviour for i2c_write command is
> "use raw i2c write only if reg address is not defined".
> Before the commit 34fadb685905 reg address == 0
> was acceptable. After the commit 34fadb685905 reg address == 0
> became unacceptable ("undefined") and will lead to raw i2c write.
>
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> ---
> commands/i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks
Sascha
>
> diff --git a/commands/i2c.c b/commands/i2c.c
> index 21c39fe5af..f0d16af0cb 100644
> --- a/commands/i2c.c
> +++ b/commands/i2c.c
> @@ -131,7 +131,7 @@ static int do_i2c_write(int argc, char *argv[])
> for (i = 0; i < count; i++)
> *(buf + i) = (char) simple_strtol(argv[optind+i], NULL, 0);
>
> - if (reg > 0) {
> + if (reg >= 0) {
> ret = i2c_write_reg(&client, reg | wide, buf, count);
> } else {
> ret = i2c_master_send(&client, buf, count);
> --
> 2.17.0
>
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2018-04-17 7:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-17 3:58 Antony Pavlov
2018-04-17 7:25 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180417072522.u3tvxjph5vehw4bt@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox