mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] watchdog: omap: set hwdev before call watchdog_register
@ 2018-04-22 18:30 Andreas Schmidt
  2018-04-25  8:36 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Andreas Schmidt @ 2018-04-22 18:30 UTC (permalink / raw)
  To: barebox

Since watchdog_register access to hwdev (see
commit 65a644388e845bde01215bf378d4df2a6a260a6a)
hwdev has to be initiate/set before calling watchdog_register.

Signed-off-by: Andreas Schmidt <mail@schmidt-andreas.de>
---
 drivers/watchdog/omap_wdt.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/watchdog/omap_wdt.c b/drivers/watchdog/omap_wdt.c
index 27fdfd13a..c8a7ccf60 100644
--- a/drivers/watchdog/omap_wdt.c
+++ b/drivers/watchdog/omap_wdt.c
@@ -160,6 +160,7 @@ static int omap_wdt_probe(struct device_d *dev)
 
 	wdev = xzalloc(sizeof(*wdev));
 	wdev->wdog.set_timeout	= omap_wdt_set_timeout;
+	wdev->wdog.hwdev = dev;
 	wdev->wdt_trgr_pattern	= 0x1234;
 
 	/* reserve static register mappings */
-- 
2.14.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] watchdog: omap: set hwdev before call watchdog_register
  2018-04-22 18:30 [PATCH] watchdog: omap: set hwdev before call watchdog_register Andreas Schmidt
@ 2018-04-25  8:36 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2018-04-25  8:36 UTC (permalink / raw)
  To: Andreas Schmidt; +Cc: barebox

On Sun, Apr 22, 2018 at 08:30:07PM +0200, Andreas Schmidt wrote:
> Since watchdog_register access to hwdev (see
> commit 65a644388e845bde01215bf378d4df2a6a260a6a)
> hwdev has to be initiate/set before calling watchdog_register.
> 
> Signed-off-by: Andreas Schmidt <mail@schmidt-andreas.de>
> ---
>  drivers/watchdog/omap_wdt.c | 1 +
>  1 file changed, 1 insertion(+)

Applied, thanks

Sascha

> 
> diff --git a/drivers/watchdog/omap_wdt.c b/drivers/watchdog/omap_wdt.c
> index 27fdfd13a..c8a7ccf60 100644
> --- a/drivers/watchdog/omap_wdt.c
> +++ b/drivers/watchdog/omap_wdt.c
> @@ -160,6 +160,7 @@ static int omap_wdt_probe(struct device_d *dev)
>  
>  	wdev = xzalloc(sizeof(*wdev));
>  	wdev->wdog.set_timeout	= omap_wdt_set_timeout;
> +	wdev->wdog.hwdev = dev;
>  	wdev->wdt_trgr_pattern	= 0x1234;
>  
>  	/* reserve static register mappings */
> -- 
> 2.14.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-04-25  8:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-22 18:30 [PATCH] watchdog: omap: set hwdev before call watchdog_register Andreas Schmidt
2018-04-25  8:36 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox