* [PATCH] video: tc358767: don't link AUX i2c adapter to parent OF node
@ 2018-04-20 10:35 Lucas Stach
2018-04-25 9:34 ` Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Lucas Stach @ 2018-04-20 10:35 UTC (permalink / raw)
To: barebox
Otherwise the i2c core will try to populate the TC358767 child nodes
as i2c devices, which is wrong.
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
drivers/video/tc358767.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/video/tc358767.c b/drivers/video/tc358767.c
index d4749b15c7a1..125e8236c153 100644
--- a/drivers/video/tc358767.c
+++ b/drivers/video/tc358767.c
@@ -1413,7 +1413,6 @@ static int tc_probe(struct device_d *dev)
tc->adapter.master_xfer = tc_aux_i2c_xfer;
tc->adapter.nr = -1; /* any free */
tc->adapter.dev.parent = dev;
- tc->adapter.dev.device_node = dev->device_node;
/* Add I2C adapter */
ret = i2c_add_numbered_adapter(&tc->adapter);
if (ret < 0) {
--
2.16.3
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] video: tc358767: don't link AUX i2c adapter to parent OF node
2018-04-20 10:35 [PATCH] video: tc358767: don't link AUX i2c adapter to parent OF node Lucas Stach
@ 2018-04-25 9:34 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2018-04-25 9:34 UTC (permalink / raw)
To: Lucas Stach; +Cc: barebox
On Fri, Apr 20, 2018 at 12:35:41PM +0200, Lucas Stach wrote:
> Otherwise the i2c core will try to populate the TC358767 child nodes
> as i2c devices, which is wrong.
>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> drivers/video/tc358767.c | 1 -
> 1 file changed, 1 deletion(-)
Applied, thanks
Sascha
>
> diff --git a/drivers/video/tc358767.c b/drivers/video/tc358767.c
> index d4749b15c7a1..125e8236c153 100644
> --- a/drivers/video/tc358767.c
> +++ b/drivers/video/tc358767.c
> @@ -1413,7 +1413,6 @@ static int tc_probe(struct device_d *dev)
> tc->adapter.master_xfer = tc_aux_i2c_xfer;
> tc->adapter.nr = -1; /* any free */
> tc->adapter.dev.parent = dev;
> - tc->adapter.dev.device_node = dev->device_node;
> /* Add I2C adapter */
> ret = i2c_add_numbered_adapter(&tc->adapter);
> if (ret < 0) {
> --
> 2.16.3
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-04-25 9:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-20 10:35 [PATCH] video: tc358767: don't link AUX i2c adapter to parent OF node Lucas Stach
2018-04-25 9:34 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox