* [PATCH] ARM: i.MX7: Remove unnecessary local variable
@ 2018-04-27 5:32 Andrey Smirnov
2018-05-02 10:26 ` Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Andrey Smirnov @ 2018-04-27 5:32 UTC (permalink / raw)
To: barebox; +Cc: Andrey Smirnov
It looks this code was based on analogous code for i.MX6, but there
that variable was being used as a part of following switch
statement. Since this is not the case for i.MX7, just replace the
variable with direct function call.
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
arch/arm/mach-imx/imx7.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/arch/arm/mach-imx/imx7.c b/arch/arm/mach-imx/imx7.c
index 5ad91c2d7..e49baf6f7 100644
--- a/arch/arm/mach-imx/imx7.c
+++ b/arch/arm/mach-imx/imx7.c
@@ -182,7 +182,6 @@ static const struct imx_reset_reason imx7_reset_reasons[] = {
int imx7_init(void)
{
const char *cputypestr;
- u32 imx7_silicon_revision;
void __iomem *src = IOMEM(MX7_SRC_BASE_ADDR);
imx7_init_lowlevel();
@@ -193,8 +192,6 @@ int imx7_init(void)
imx7_boot_save_loc();
- imx7_silicon_revision = imx7_cpu_revision();
-
psci_set_ops(&imx7_psci_ops);
switch (imx7_cpu_type()) {
@@ -209,7 +206,7 @@ int imx7_init(void)
break;
}
- imx_set_silicon_revision(cputypestr, imx7_silicon_revision);
+ imx_set_silicon_revision(cputypestr, imx7_cpu_revision());
imx_set_reset_reason(src + IMX7_SRC_SRSR, imx7_reset_reasons);
return 0;
--
2.14.3
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: i.MX7: Remove unnecessary local variable
2018-04-27 5:32 [PATCH] ARM: i.MX7: Remove unnecessary local variable Andrey Smirnov
@ 2018-05-02 10:26 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2018-05-02 10:26 UTC (permalink / raw)
To: Andrey Smirnov; +Cc: barebox
On Thu, Apr 26, 2018 at 10:32:16PM -0700, Andrey Smirnov wrote:
> It looks this code was based on analogous code for i.MX6, but there
> that variable was being used as a part of following switch
> statement. Since this is not the case for i.MX7, just replace the
> variable with direct function call.
>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
> arch/arm/mach-imx/imx7.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
Applied, thanks
Sascha
>
> diff --git a/arch/arm/mach-imx/imx7.c b/arch/arm/mach-imx/imx7.c
> index 5ad91c2d7..e49baf6f7 100644
> --- a/arch/arm/mach-imx/imx7.c
> +++ b/arch/arm/mach-imx/imx7.c
> @@ -182,7 +182,6 @@ static const struct imx_reset_reason imx7_reset_reasons[] = {
> int imx7_init(void)
> {
> const char *cputypestr;
> - u32 imx7_silicon_revision;
> void __iomem *src = IOMEM(MX7_SRC_BASE_ADDR);
>
> imx7_init_lowlevel();
> @@ -193,8 +192,6 @@ int imx7_init(void)
>
> imx7_boot_save_loc();
>
> - imx7_silicon_revision = imx7_cpu_revision();
> -
> psci_set_ops(&imx7_psci_ops);
>
> switch (imx7_cpu_type()) {
> @@ -209,7 +206,7 @@ int imx7_init(void)
> break;
> }
>
> - imx_set_silicon_revision(cputypestr, imx7_silicon_revision);
> + imx_set_silicon_revision(cputypestr, imx7_cpu_revision());
> imx_set_reset_reason(src + IMX7_SRC_SRSR, imx7_reset_reasons);
>
> return 0;
> --
> 2.14.3
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-02 10:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-27 5:32 [PATCH] ARM: i.MX7: Remove unnecessary local variable Andrey Smirnov
2018-05-02 10:26 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox