From: Sascha Hauer <sha@pengutronix.de>
To: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
Cc: Andrew Lunn <andrew@lunn.ch>, Chris Healy <cphealy@gmail.com>,
barebox@lists.infradead.org
Subject: Re: [PATCH] usbnet: increase bulk message timeout
Date: Wed, 2 May 2018 12:15:22 +0200 [thread overview]
Message-ID: <20180502101522.socnzxrz3d37frgf@pengutronix.de> (raw)
In-Reply-To: <216a62f9-5450-5ed6-945f-b3d26d65ae3e@cogentembedded.com>
On Thu, Apr 26, 2018 at 04:02:48PM +0300, Nikita Yushchenko wrote:
> Timeout of 1ms is too low for case when device operates in Full Speed
> mode. This causes most incoming frames to be lost.
>
> Since timeout is only used to get out of polling loop in case of no
> response from hardware, increasing it should be safe for all platforms.
>
> Signed-off-by: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
> Tested-By: Andrew Lunn <andrew@lunn.ch>
> ---
Applied, thanks.
The patch is whitespace damaged, I fixed this up manually this time.
Sascha
> drivers/net/usb/usbnet.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
> index 33d900b70..60e67ff1a 100644
> --- a/drivers/net/usb/usbnet.c
> +++ b/drivers/net/usb/usbnet.c
> @@ -125,7 +125,7 @@ static int usbnet_recv(struct eth_device *edev)
> len = dev->rx_urb_size;
> - ret = usb_bulk_msg(dev->udev, dev->in, rx_buf, len, &alen, 1);
> + ret = usb_bulk_msg(dev->udev, dev->in, rx_buf, len, &alen, 100);
> if (ret)
> return ret;
> -- 2.11.0
>
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2018-05-02 10:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-26 13:02 Nikita Yushchenko
2018-05-02 10:15 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180502101522.socnzxrz3d37frgf@pengutronix.de \
--to=sha@pengutronix.de \
--cc=andrew@lunn.ch \
--cc=barebox@lists.infradead.org \
--cc=cphealy@gmail.com \
--cc=nikita.yoush@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox