From: Sascha Hauer <s.hauer@pengutronix.de>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/2] watchdog: Port RAVE SP watchdog driver from Linux kernel
Date: Wed, 2 May 2018 12:24:36 +0200 [thread overview]
Message-ID: <20180502102436.avptoe2l6h4hpkqy@pengutronix.de> (raw)
In-Reply-To: <20180421013338.10115-3-andrew.smirnov@gmail.com>
On Fri, Apr 20, 2018 at 06:33:38PM -0700, Andrey Smirnov wrote:
> +static int rave_sp_wdt_set_timeout(struct watchdog *wdd,
> + unsigned int timeout)
> +{
> + struct rave_sp_wdt *sp_wd = to_rave_sp_wdt(wdd);
> +
> + if (timeout < sp_wd->variant->min_timeout ||
> + timeout > sp_wd->variant->max_timeout)
> + return -EINVAL;
> +
> + if (!timeout)
> + return rave_sp_wdt_stop(wdd);
Since min_timeout is > 0 this is never reached. You should move this up.
Otherwise the patches look fine.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2018-05-02 10:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-21 1:33 [PATCH 0/2] Initial RAVE SP Linux driver port Andrey Smirnov
2018-04-21 1:33 ` [PATCH 1/2] mfd: Port RAVE SP driver from Linux kernel Andrey Smirnov
2018-04-21 1:33 ` [PATCH 2/2] watchdog: Port RAVE SP watchdog " Andrey Smirnov
2018-05-02 10:24 ` Sascha Hauer [this message]
2018-05-02 17:47 ` Andrey Smirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180502102436.avptoe2l6h4hpkqy@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox