From: Sascha Hauer <s.hauer@pengutronix.de>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] ARM: i.MX7: Remove unnecessary local variable
Date: Wed, 2 May 2018 12:26:28 +0200 [thread overview]
Message-ID: <20180502102628.xuzgf3o6aeijxl6z@pengutronix.de> (raw)
In-Reply-To: <20180427053216.10040-1-andrew.smirnov@gmail.com>
On Thu, Apr 26, 2018 at 10:32:16PM -0700, Andrey Smirnov wrote:
> It looks this code was based on analogous code for i.MX6, but there
> that variable was being used as a part of following switch
> statement. Since this is not the case for i.MX7, just replace the
> variable with direct function call.
>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
> arch/arm/mach-imx/imx7.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
Applied, thanks
Sascha
>
> diff --git a/arch/arm/mach-imx/imx7.c b/arch/arm/mach-imx/imx7.c
> index 5ad91c2d7..e49baf6f7 100644
> --- a/arch/arm/mach-imx/imx7.c
> +++ b/arch/arm/mach-imx/imx7.c
> @@ -182,7 +182,6 @@ static const struct imx_reset_reason imx7_reset_reasons[] = {
> int imx7_init(void)
> {
> const char *cputypestr;
> - u32 imx7_silicon_revision;
> void __iomem *src = IOMEM(MX7_SRC_BASE_ADDR);
>
> imx7_init_lowlevel();
> @@ -193,8 +192,6 @@ int imx7_init(void)
>
> imx7_boot_save_loc();
>
> - imx7_silicon_revision = imx7_cpu_revision();
> -
> psci_set_ops(&imx7_psci_ops);
>
> switch (imx7_cpu_type()) {
> @@ -209,7 +206,7 @@ int imx7_init(void)
> break;
> }
>
> - imx_set_silicon_revision(cputypestr, imx7_silicon_revision);
> + imx_set_silicon_revision(cputypestr, imx7_cpu_revision());
> imx_set_reset_reason(src + IMX7_SRC_SRSR, imx7_reset_reasons);
>
> return 0;
> --
> 2.14.3
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2018-05-02 10:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-27 5:32 Andrey Smirnov
2018-05-02 10:26 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180502102628.xuzgf3o6aeijxl6z@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox