mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: barebox@lists.infradead.org
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>
Subject: [PATCH v2 26/28] ARM: mmu: Simplify the use of dma_flush_range()
Date: Wed, 16 May 2018 13:00:34 -0700	[thread overview]
Message-ID: <20180516200036.29829-27-andrew.smirnov@gmail.com> (raw)
In-Reply-To: <20180516200036.29829-1-andrew.smirnov@gmail.com>

Simplify the use of dma_flush_range() by changing its signature to
accept pointer to start of the data and data size. This change allows
us to avoid a whole bunch of repetitive arithmetic currently done by
all of the callers.

Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
 arch/arm/cpu/mmu.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/arch/arm/cpu/mmu.c b/arch/arm/cpu/mmu.c
index b14a869af..30f321691 100644
--- a/arch/arm/cpu/mmu.c
+++ b/arch/arm/cpu/mmu.c
@@ -142,8 +142,11 @@ static u32 *find_pte(unsigned long adr)
 	return &table[(adr >> PAGE_SHIFT) & 0xff];
 }
 
-static void dma_flush_range(unsigned long start, unsigned long end)
+static void dma_flush_range(void *ptr, size_t size)
 {
+	unsigned long start = (unsigned long)ptr;
+	unsigned long end = start + size;
+
 	__dma_flush_range(start, end);
 	if (outer_cache.flush_range)
 		outer_cache.flush_range(start, end);
@@ -170,9 +173,7 @@ static int __remap_range(void *_start, size_t size, u32 pte_flags)
 		p[i] |= pte_flags | PTE_TYPE_SMALL;
 	}
 
-	dma_flush_range((unsigned long)p,
-			(unsigned long)p + numentries * sizeof(u32));
-
+	dma_flush_range(p, numentries * sizeof(u32));
 	tlb_invalidate();
 
 	return 0;
@@ -203,7 +204,7 @@ void *map_io_sections(unsigned long phys, void *_start, size_t size)
 	for (sec = start; sec < start + size; sec += PGDIR_SIZE, phys += PGDIR_SIZE)
 		ttb[pgd_index(sec)] = phys | PMD_SECT_DEF_UNCACHED;
 
-	dma_flush_range((unsigned long)ttb, (unsigned long)ttb + 0x4000);
+	dma_flush_range(ttb, 0x4000);
 	tlb_invalidate();
 	return _start;
 }
@@ -249,9 +250,8 @@ static int arm_mmu_remap_sdram(struct memory_bank *bank)
 		pte += PTRS_PER_PTE;
 	}
 
-	dma_flush_range((unsigned long)ttb, (unsigned long)ttb + 0x4000);
-	dma_flush_range((unsigned long)ptes,
-			(unsigned long)ptes + num_ptes * sizeof(u32));
+	dma_flush_range(ttb, 0x4000);
+	dma_flush_range(ptes, num_ptes * sizeof(u32));
 
 	tlb_invalidate();
 
-- 
2.17.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2018-05-16 20:01 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-16 20:00 [PATCH v2 00/28] ARM MMU code improvements and on-demand PTE allocation Andrey Smirnov
2018-05-16 20:00 ` [PATCH v2 01/28] ARM: mmu: Remove unused ARM_VECTORS_SIZE Andrey Smirnov
2018-05-16 20:00 ` [PATCH v2 02/28] ARM: mmu: Make use of IS_ALIGNED in arm_mmu_remap_sdram() Andrey Smirnov
2018-05-16 20:00 ` [PATCH v2 03/28] ARM: mmu: Use ALIGN and ALIGN_DOWN in map_cachable() Andrey Smirnov
2018-05-16 20:00 ` [PATCH v2 04/28] ARM: mmu: Introduce set_ttbr() Andrey Smirnov
2018-05-16 20:00 ` [PATCH v2 05/28] ARM: mmu: Introduce set_domain() Andrey Smirnov
2018-05-16 20:00 ` [PATCH v2 06/28] ARM: mmu: Share code for create_sections() Andrey Smirnov
2018-05-16 20:49   ` Sam Ravnborg
2018-05-17  0:10     ` Andrey Smirnov
2018-05-16 20:00 ` [PATCH v2 07/28] ARM: mmu: Separate index and address in create_sections() Andrey Smirnov
2018-05-16 20:52   ` Sam Ravnborg
2018-05-17  0:11     ` Andrey Smirnov
2018-05-16 20:00 ` [PATCH v2 08/28] sizes.h: Sync with Linux 4.16 Andrey Smirnov
2018-05-16 20:00 ` [PATCH v2 09/28] ARM: mmu: Specify size in bytes in create_sections() Andrey Smirnov
2018-05-17  6:55   ` Sascha Hauer
2018-05-17  7:01     ` Andrey Smirnov
2018-05-17  7:08       ` Sascha Hauer
2018-05-17  7:35         ` Andrey Smirnov
2018-05-17  9:24           ` Sascha Hauer
2018-05-16 20:00 ` [PATCH v2 10/28] ARM: mmu: Share code for initial flat mapping creation Andrey Smirnov
2018-05-16 20:00 ` [PATCH v2 11/28] ARM: mmu: Share PMD_SECT_DEF_CACHED Andrey Smirnov
2018-05-16 20:00 ` [PATCH v2 12/28] ARM: mmu: Drop needless shifting in map_io_sections() Andrey Smirnov
2018-05-16 20:00 ` [PATCH v2 13/28] ARM: mmu: Replace hardcoded shifts with pgd_index() from Linux Andrey Smirnov
2018-05-16 20:00 ` [PATCH v2 14/28] ARM: mmu: Trivial simplification in arm_mmu_remap_sdram() Andrey Smirnov
2018-05-16 20:00 ` [PATCH v2 15/28] ARM: mmu: Replace various SZ_1M with PGDIR_SIZE Andrey Smirnov
2018-05-16 20:00 ` [PATCH v2 16/28] ARM: mmu: Use PAGE_SIZE when specifying size of one page Andrey Smirnov
2018-05-16 20:00 ` [PATCH v2 17/28] ARM: mmu: Define and use PTRS_PER_PTE Andrey Smirnov
2018-05-16 20:00 ` [PATCH v2 18/28] ARM: mmu: Use PAGE_SIZE instead of magic right shift by 12 Andrey Smirnov
2018-05-16 20:00 ` [PATCH v2 19/28] ARM: mmu: Use xmemalign in arm_create_pte() Andrey Smirnov
2018-05-16 20:00 ` [PATCH v2 20/28] ARM: mmu: Use xmemalign in mmu_init() Andrey Smirnov
2018-05-16 20:00 ` [PATCH v2 21/28] ARM: mmu: Share code between dma_alloc_*() functions Andrey Smirnov
2018-05-16 20:00 ` [PATCH v2 22/28] ARM: mmu: Pass PTE flags a parameter to arm_create_pte() Andrey Smirnov
2018-05-16 20:00 ` [PATCH v2 23/28] ARM: mmu: Make sure that address is 1M aligned in arm_create_pte() Andrey Smirnov
2018-05-16 20:00 ` [PATCH v2 24/28] ARM: mmu: Use find_pte() to find PTE in create_vector_table() Andrey Smirnov
2018-05-16 20:00 ` [PATCH v2 25/28] ARM: mmu: Use dma_inv_range() in dma_sync_single_for_cpu() Andrey Smirnov
2018-05-16 20:00 ` Andrey Smirnov [this message]
2018-05-16 20:00 ` [PATCH v2 27/28] ARM: mmu: Implement on-demand PTE allocation Andrey Smirnov
2018-05-16 20:00 ` [PATCH v2 28/28] ARM: mmu: Introduce ARM_TTB_SIZE Andrey Smirnov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180516200036.29829-27-andrew.smirnov@gmail.com \
    --to=andrew.smirnov@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox