From: Peter Mamonov <pmamonov@gmail.com>
To: barebox@lists.infradead.org
Cc: Peter Mamonov <pmamonov@gmail.com>
Subject: [RFC PATCH 05/15] mips: fix dma_sync_* stuff for MIPS64
Date: Thu, 17 May 2018 16:58:48 +0300 [thread overview]
Message-ID: <20180517135858.16202-6-pmamonov@gmail.com> (raw)
In-Reply-To: <20180517135858.16202-1-pmamonov@gmail.com>
Signed-off-by: Peter Mamonov <pmamonov@gmail.com>
---
arch/mips/include/asm/dma-mapping.h | 2 +-
arch/mips/include/asm/io.h | 4 ++--
arch/mips/lib/c-r4k.c | 26 +++++++++++++-------------
arch/mips/lib/dma-default.c | 6 ++++--
4 files changed, 20 insertions(+), 18 deletions(-)
diff --git a/arch/mips/include/asm/dma-mapping.h b/arch/mips/include/asm/dma-mapping.h
index c71a08703..d4cbb3cac 100644
--- a/arch/mips/include/asm/dma-mapping.h
+++ b/arch/mips/include/asm/dma-mapping.h
@@ -19,7 +19,7 @@ static inline void *dma_alloc_coherent(size_t size, dma_addr_t *dma_handle)
if (dma_handle)
*dma_handle = CPHYSADDR(ret);
- dma_flush_range((unsigned long)ret, (unsigned long)(ret + size));
+ dma_flush_range(ret, ret + size);
return (void *)CKSEG1ADDR(ret);
}
diff --git a/arch/mips/include/asm/io.h b/arch/mips/include/asm/io.h
index 5a4cbf564..07b337e76 100644
--- a/arch/mips/include/asm/io.h
+++ b/arch/mips/include/asm/io.h
@@ -15,8 +15,8 @@
#include <asm/addrspace.h>
#include <asm/byteorder.h>
-void dma_flush_range(unsigned long, unsigned long);
-void dma_inv_range(unsigned long, unsigned long);
+void dma_flush_range(void *, void *);
+void dma_inv_range(void *, void *);
/*
* virt_to_phys - map virtual addresses to physical
diff --git a/arch/mips/lib/c-r4k.c b/arch/mips/lib/c-r4k.c
index cb0544a53..2d652be61 100644
--- a/arch/mips/lib/c-r4k.c
+++ b/arch/mips/lib/c-r4k.c
@@ -27,12 +27,12 @@
: "i" (op), "R" (*(unsigned char *)(addr)))
#define __BUILD_BLAST_CACHE_RANGE(pfx, desc, hitop) \
-static inline void blast_##pfx##cache##_range(unsigned long start, \
- unsigned long end) \
+static inline void blast_##pfx##cache##_range(void *start, \
+ void *end) \
{ \
- unsigned long lsize = current_cpu_data.desc.linesz; \
- unsigned long addr = start & ~(lsize - 1); \
- unsigned long aend = (end - 1) & ~(lsize - 1); \
+ uintptr_t lsize = current_cpu_data.desc.linesz; \
+ void *addr = (void *)((uintptr_t)start & ~(lsize - 1)); \
+ void *aend = (void *)(((uintptr_t)end - 1) & ~(lsize - 1)); \
\
if (current_cpu_data.desc.flags & MIPS_CACHE_NOT_PRESENT) \
return; \
@@ -52,33 +52,33 @@ void flush_cache_all(void)
{
struct cpuinfo_mips *c = ¤t_cpu_data;
unsigned long lsize;
- unsigned long addr;
- unsigned long aend;
+ void *addr;
+ void *aend;
unsigned int icache_size, dcache_size;
dcache_size = c->dcache.waysize * c->dcache.ways;
lsize = c->dcache.linesz;
- aend = (CKSEG0 + dcache_size - 1) & ~(lsize - 1);
- for (addr = CKSEG0; addr <= aend; addr += lsize)
+ aend = (void *)((CKSEG0 + dcache_size - 1) & ~(lsize - 1));
+ for (addr = (void *)CKSEG0; addr <= aend; addr += lsize)
cache_op(Index_Writeback_Inv_D, addr);
icache_size = c->icache.waysize * c->icache.ways;
lsize = c->icache.linesz;
- aend = (CKSEG0 + icache_size - 1) & ~(lsize - 1);
- for (addr = CKSEG0; addr <= aend; addr += lsize)
+ aend = (void *)((CKSEG0 + icache_size - 1) & ~(lsize - 1));
+ for (addr = (void *)CKSEG0; addr <= aend; addr += lsize)
cache_op(Index_Invalidate_I, addr);
/* secondatory cache skipped */
}
-void dma_flush_range(unsigned long start, unsigned long end)
+void dma_flush_range(void *start, void *end)
{
blast_dcache_range(start, end);
/* secondatory cache skipped */
}
-void dma_inv_range(unsigned long start, unsigned long end)
+void dma_inv_range(void *start, void *end)
{
blast_inv_dcache_range(start, end);
diff --git a/arch/mips/lib/dma-default.c b/arch/mips/lib/dma-default.c
index 71c1e423b..79d61afd8 100644
--- a/arch/mips/lib/dma-default.c
+++ b/arch/mips/lib/dma-default.c
@@ -17,9 +17,11 @@
#if defined(CONFIG_CPU_MIPS32) || \
defined(CONFIG_CPU_MIPS64)
-static inline void __dma_sync_mips(unsigned long addr, size_t size,
+static inline void __dma_sync_mips(dma_addr_t _addr, size_t size,
enum dma_data_direction direction)
{
+ void *addr = (void *)CKSEG0ADDR(_addr);
+
switch (direction) {
case DMA_TO_DEVICE:
dma_flush_range(addr, addr + size);
@@ -38,7 +40,7 @@ static inline void __dma_sync_mips(unsigned long addr, size_t size,
}
}
#else
-static inline void __dma_sync_mips(void *addr, size_t size,
+static inline void __dma_sync_mips(dma_addr_t _addr, size_t size,
enum dma_data_direction direction)
{
}
--
2.17.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2018-05-17 13:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 13:58 [RFC PATCH 00/15] MIPS64 support Peter Mamonov
2018-05-17 13:58 ` [RFC PATCH 01/15] FIXME: add t4..t7 definitions for MIPS64 Peter Mamonov
2018-05-17 13:58 ` [RFC PATCH 02/15] MIPS: use CKSEG1 instead of KSEG1 Peter Mamonov
2018-05-17 13:58 ` [RFC PATCH 03/15] FIXME: mips: fix copy_to_link_location for 64 bit mode Peter Mamonov
2018-05-17 13:58 ` [RFC PATCH 04/15] mips: fix warnings from CPHYSADDR() macro Peter Mamonov
2018-05-17 13:58 ` Peter Mamonov [this message]
2018-05-18 5:57 ` [RFC PATCH 05/15] mips: fix dma_sync_* stuff for MIPS64 Sascha Hauer
2018-05-18 15:24 ` Peter Mamonov
2018-05-17 13:58 ` [RFC PATCH 06/15] common/Kconfig: add PHYS_ADDR_T_64BIT option Peter Mamonov
2018-05-17 13:58 ` [RFC PATCH 07/15] mips: 64BIT selects PHYS_ADDR_T_64BIT Peter Mamonov
2018-05-17 13:58 ` [RFC PATCH 08/15] fixup! MIPS: import optimized string functions from Linux Peter Mamonov
2018-05-17 13:58 ` [RFC PATCH 09/15] MIPS: import 64-bit address conversion macros Peter Mamonov
2018-05-17 13:58 ` [RFC PATCH 10/15] common.h: fix IOMEM() for MIPS64 Peter Mamonov
2018-05-17 13:58 ` [RFC PATCH 11/15] resource: fix iomem root resource for 64 bit Peter Mamonov
2018-05-17 21:50 ` Andrey Smirnov
2018-05-18 11:07 ` Peter Mamonov
2018-05-17 13:58 ` [RFC PATCH 12/15] FIXME: commands/mem: fix /dev/mem size Peter Mamonov
2018-05-17 13:58 ` [RFC PATCH 13/15] FIXME: fs: fix memory access for 64bit MIPS Peter Mamonov
2018-05-17 13:58 ` [RFC PATCH 14/15] mtd: cfi-flash: fix write_buff() for 64BIT Peter Mamonov
2018-05-17 13:58 ` [RFC PATCH 15/15] i2c/muxes/i2c-mux-pca954x: fix private data retrieval for 64bit mode Peter Mamonov
2018-05-17 21:34 ` Andrey Smirnov
2018-05-18 5:49 ` [RFC PATCH 00/15] MIPS64 support Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180517135858.16202-6-pmamonov@gmail.com \
--to=pmamonov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox