From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fJYOh-000574-Or for barebox@lists.infradead.org; Fri, 18 May 2018 05:57:49 +0000 Date: Fri, 18 May 2018 07:57:34 +0200 From: Sascha Hauer Message-ID: <20180518055734.sl3vlnyr7tooitih@pengutronix.de> References: <20180517135858.16202-1-pmamonov@gmail.com> <20180517135858.16202-6-pmamonov@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20180517135858.16202-6-pmamonov@gmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [RFC PATCH 05/15] mips: fix dma_sync_* stuff for MIPS64 To: Peter Mamonov Cc: barebox@lists.infradead.org On Thu, May 17, 2018 at 04:58:48PM +0300, Peter Mamonov wrote: > Signed-off-by: Peter Mamonov > --- > arch/mips/include/asm/dma-mapping.h | 2 +- > arch/mips/include/asm/io.h | 4 ++-- > arch/mips/lib/c-r4k.c | 26 +++++++++++++------------- > arch/mips/lib/dma-default.c | 6 ++++-- > 4 files changed, 20 insertions(+), 18 deletions(-) > > diff --git a/arch/mips/include/asm/dma-mapping.h b/arch/mips/include/asm/dma-mapping.h > index c71a08703..d4cbb3cac 100644 > --- a/arch/mips/include/asm/dma-mapping.h > +++ b/arch/mips/include/asm/dma-mapping.h > @@ -19,7 +19,7 @@ static inline void *dma_alloc_coherent(size_t size, dma_addr_t *dma_handle) > if (dma_handle) > *dma_handle = CPHYSADDR(ret); > > - dma_flush_range((unsigned long)ret, (unsigned long)(ret + size)); > + dma_flush_range(ret, ret + size); > > return (void *)CKSEG1ADDR(ret); > } > diff --git a/arch/mips/include/asm/io.h b/arch/mips/include/asm/io.h > index 5a4cbf564..07b337e76 100644 > --- a/arch/mips/include/asm/io.h > +++ b/arch/mips/include/asm/io.h > @@ -15,8 +15,8 @@ > #include > #include > > -void dma_flush_range(unsigned long, unsigned long); > -void dma_inv_range(unsigned long, unsigned long); > +void dma_flush_range(void *, void *); > +void dma_inv_range(void *, void *); Why is this changed? unsigned long should normally be wide enough to hold an address. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox