mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
To: barebox@lists.infradead.org
Cc: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Subject: [PATCH] net: specify device name in warning
Date: Fri, 18 May 2018 14:06:36 -0400	[thread overview]
Message-ID: <20180518180636.24885-1-vivien.didelot@savoirfairelinux.com> (raw)

When a SoC such as VF610 has no addresses programmed for both its
interfaces, the "No MAC address set" warning can be confusing:

    booting 'net'
    WARNING: net: warning: No MAC address set. Using random address a2:e8:be:79:72:01
    WARNING: net: warning: No MAC address set. Using random address aa:d5:d7:10:c0:42

This patch simply specifies the device name in the warning for clarity:

    booting 'net'
    WARNING: net: warning: No MAC address set for eth0. Using random address 5e:92:6b:b8:6e:92
    WARNING: net: warning: No MAC address set for eth1. Using random address 7e:bb:cd:7a:c1:e8

Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
---
 net/net.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/net.c b/net/net.c
index 94954677c..da7afb014 100644
--- a/net/net.c
+++ b/net/net.c
@@ -330,7 +330,7 @@ static struct net_connection *net_new(struct eth_device *edev, IPaddr_t dest,
 		char str[sizeof("xx:xx:xx:xx:xx:xx")];
 		random_ether_addr(edev->ethaddr);
 		ethaddr_to_string(edev->ethaddr, str);
-		pr_warn("warning: No MAC address set. Using random address %s\n", str);
+		pr_warn("warning: No MAC address set for %s. Using random address %s\n", edev->devname, str);
 		eth_set_ethaddr(edev, edev->ethaddr);
 	}
 
-- 
2.17.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

             reply	other threads:[~2018-05-18 18:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-18 18:06 Vivien Didelot [this message]
2018-05-18 20:20 ` Sam Ravnborg
2018-05-18 20:36   ` Vivien Didelot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180518180636.24885-1-vivien.didelot@savoirfairelinux.com \
    --to=vivien.didelot@savoirfairelinux.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox