From: Sascha Hauer <s.hauer@pengutronix.de>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Cc: barebox@lists.infradead.org, Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH v2] net: use dev_warn() when no MAC address is set
Date: Tue, 22 May 2018 08:41:57 +0200 [thread overview]
Message-ID: <20180522064157.m6hvepx4uvlil3zh@pengutronix.de> (raw)
In-Reply-To: <20180518204129.9522-1-vivien.didelot@savoirfairelinux.com>
On Fri, May 18, 2018 at 04:41:29PM -0400, Vivien Didelot wrote:
> When a SoC such as VF610 has no addresses programmed for both its
> interfaces, the "No MAC address set" warning can be confusing:
>
> booting 'net'
> WARNING: net: warning: No MAC address set. Using random address a2:e8:be:79:72:01
> WARNING: net: warning: No MAC address set. Using random address aa:d5:d7:10:c0:42
>
> This patch uses dev_warn() instead and removes the redundant "warning":
>
> booting 'net'
> WARNING: eth0: No MAC address set. Using random address a2:e8:be:79:72:01
> WARNING: eth1: No MAC address set. Using random address 4e:be:c4:bc:ce:36
>
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Applied, thanks
Sascha
> ---
> net/net.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/net.c b/net/net.c
> index 94954677c..d21855415 100644
> --- a/net/net.c
> +++ b/net/net.c
> @@ -330,7 +330,7 @@ static struct net_connection *net_new(struct eth_device *edev, IPaddr_t dest,
> char str[sizeof("xx:xx:xx:xx:xx:xx")];
> random_ether_addr(edev->ethaddr);
> ethaddr_to_string(edev->ethaddr, str);
> - pr_warn("warning: No MAC address set. Using random address %s\n", str);
> + dev_warn(&edev->dev, "No MAC address set. Using random address %s\n", str);
> eth_set_ethaddr(edev, edev->ethaddr);
> }
>
> --
> 2.17.0
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2018-05-22 6:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-18 20:41 Vivien Didelot
2018-05-18 20:44 ` Sam Ravnborg
2018-05-22 6:41 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180522064157.m6hvepx4uvlil3zh@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=sam@ravnborg.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox