From: Sascha Hauer <s.hauer@pengutronix.de>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] scripts/mkimage: Fix strncpy usage
Date: Wed, 23 May 2018 10:12:59 +0200 [thread overview]
Message-ID: <20180523081259.axqonqh3eaguaigp@pengutronix.de> (raw)
In-Reply-To: <20180522222644.26425-1-andrew.smirnov@gmail.com>
On Tue, May 22, 2018 at 03:26:44PM -0700, Andrey Smirnov wrote:
> Original code produces the following warning when compiled with GCC8:
>
> HOSTCC scripts/mkimage
> In function ‘image_set_name’,
> inlined from ‘main’ at scripts/mkimage.c:614:2:
> scripts/mkimage.c:153:2: warning: ‘strncpy’ specified bound 32 equals destination size [-Wstringop-truncation]
> strncpy(image_get_name(hdr), name, IH_NMLEN);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> reduce specified bound by one to make sure that NULL-terminator is
> never overwritten.
>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
> scripts/mkimage.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks
Sascha
>
> diff --git a/scripts/mkimage.c b/scripts/mkimage.c
> index c7267a2d1..891d7b6de 100644
> --- a/scripts/mkimage.c
> +++ b/scripts/mkimage.c
> @@ -150,7 +150,7 @@ image_set_hdr_u8(comp); /* image_set_comp */
>
> static inline void image_set_name(image_header_t *hdr, const char *name)
> {
> - strncpy(image_get_name(hdr), name, IH_NMLEN);
> + strncpy(image_get_name(hdr), name, IH_NMLEN - 1);
> }
>
> /**
> --
> 2.17.0
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2018-05-23 8:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-22 22:26 Andrey Smirnov
2018-05-23 8:12 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180523081259.axqonqh3eaguaigp@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox