mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Baeuerle, Florian" <Florian.Baeuerle@allegion.com>
Cc: "barebox@lists.infradead.org" <barebox@lists.infradead.org>
Subject: Re: Modifying device-tree: /chosen
Date: Wed, 23 May 2018 15:30:30 +0200	[thread overview]
Message-ID: <20180523133030.tjxqfxri5fxbaxor@pengutronix.de> (raw)
In-Reply-To: <7b0617ad32db44235a2f7efbe19b31e802a9493b.camel@allegion.com>

Hi Florian,

On Wed, May 23, 2018 at 10:59:21AM +0000, Baeuerle, Florian wrote:
> Hi,
> 
> I haven't found a (good) way to modify the kernel device tree before booting
> when using the bootchooser in combination with blspec.  What seems to be done
> quite often is registering fixup functions (of_register_fixup) in board-specific
> code.
> 
> I'd prefer not patch board-specific code, because my use case is rather specific
> (passing the device serial number, the bootloader version, and a few other
> things to the kernel). So the question is, if this use case is common enough to
> provide a more generic way.
> 
> My proposal is providing a command like this:
> 
> of_fixup_chosen [PROPERTY] [VALUE]

This seems to be very similar to what I suggested here:

https://www.spinics.net/lists/u-boot-v2/msg32661.html

I see no reason to limit this command to the /chosen node, we could
equally well accept a full path to the node rather than just a property
name.

> 
> I guess it would suffice to only store strings in /chosen.
> 
> Example:
> of_fixup_chosen bootloader-version $global.version

This is already done, See commit e96dc23280c43dd6b026ea71bcbaf3353abb4c83

> of_fixup_chosen reset-reason $global.system.reset

See 58243d98b3f8e000c674a78a9466bd2fce213cc6

> of_fixup_chosen serial $serial_number

No generic support for this one though.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2018-05-23 13:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-23 10:59 Baeuerle, Florian
2018-05-23 12:55 ` Pascal Vizeli
2018-05-23 13:30 ` Sascha Hauer [this message]
     [not found]   ` <e77f7ef6c9ab77ca5fb2cdee4125efa6c9ae8fd2.camel@allegion.com>
     [not found]     ` <20180524082047.44njsmnrvpxyar27@pengutronix.de>
2018-05-24 14:12       ` Baeuerle, Florian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180523133030.tjxqfxri5fxbaxor@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=Florian.Baeuerle@allegion.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox