From: Sascha Hauer <s.hauer@pengutronix.de>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v1] imx-usb-loader: skip image verification on iMX25
Date: Thu, 24 May 2018 07:50:31 +0200 [thread overview]
Message-ID: <20180524055031.3yhrutrqjtqzpyi2@pengutronix.de> (raw)
In-Reply-To: <20180523112150.12925-1-o.rempel@pengutronix.de>
On Wed, May 23, 2018 at 01:21:50PM +0200, Oleksij Rempel wrote:
> it is broken an multiple MX25 based devices and
> we have no information how to fix it.
>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Dropped in favour for a patch fixing the problem.
Sascha
> ---
> scripts/imx/imx-usb-loader.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/scripts/imx/imx-usb-loader.c b/scripts/imx/imx-usb-loader.c
> index 43dde8b7f..399bc2a9c 100644
> --- a/scripts/imx/imx-usb-loader.c
> +++ b/scripts/imx/imx-usb-loader.c
> @@ -72,6 +72,9 @@ struct mach_id {
> #define DEV_IMX 0
> #define DEV_MXS 1
> unsigned char dev_type;
> + unsigned char verify_mode;
> +#define VER_DEFAULT 0
> +#define VER_SKIP 1
> };
>
> struct usb_work {
> @@ -107,6 +110,7 @@ static const struct mach_id imx_ids[] = {
> .header_type = HDR_MX51,
> .mode = MODE_BULK,
> .max_transfer = 64,
> + .verify_mode = VER_SKIP,
> }, {
> .vid = 0x15a2,
> .pid = 0x0041,
> @@ -1346,6 +1350,7 @@ static int do_irom_download(struct usb_work *curr, int verify)
> unsigned plugin = 0;
> unsigned header_addr = 0;
> unsigned skip = 0;
> + const struct mach_id *id = usb_id->mach_id;
>
> ret = read_file(curr->filename, &buf, &fsize);
> if (ret < 0)
> @@ -1394,6 +1399,11 @@ static int do_irom_download(struct usb_work *curr, int verify)
>
> type = FT_APP;
>
> + if (id->verify_mode == VER_SKIP) {
> + printf("Verification of flashed image is not supported. Skipping.\n");
> + verify = 0;
> + }
> +
> if (verify) {
> verify_buffer = malloc(64);
>
> --
> 2.17.0
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2018-05-24 5:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-23 11:21 Oleksij Rempel
2018-05-24 5:50 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180524055031.3yhrutrqjtqzpyi2@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=o.rempel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox