mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: barebox@lists.infradead.org
Subject: [PATCH v3 01/38] ARM: i.MX: xload: Fix compiler warning
Date: Wed,  6 Jun 2018 11:43:54 -0700	[thread overview]
Message-ID: <20180606184431.10348-2-andrew.smirnov@gmail.com> (raw)
In-Reply-To: <20180606184431.10348-1-andrew.smirnov@gmail.com>

From: Sascha Hauer <s.hauer@pengutronix.de>

the ESDHC controller is a 32bit device, so can do DMA only on the
lower 32bit. Fix the compiler warning about casting a pointer to integer
of different size on aarch64 by casting to unsigned long first. Error
out if the destination does not fit into 32bit though.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 arch/arm/mach-imx/xload-esdhc.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/arch/arm/mach-imx/xload-esdhc.c b/arch/arm/mach-imx/xload-esdhc.c
index e774e4e68..bd58bdc64 100644
--- a/arch/arm/mach-imx/xload-esdhc.c
+++ b/arch/arm/mach-imx/xload-esdhc.c
@@ -109,8 +109,13 @@ esdhc_send_cmd(struct esdhc *esdhc, struct mci_cmd *cmd, struct mci_data *data)
 	__udelay(1);
 
 	if (data) {
+		unsigned long dest = (unsigned long)data->dest;
+
+		if (dest > 0xffffffff)
+			return -EINVAL;
+
 		/* Set up for a data transfer if we have one */
-		esdhc_write32(regs + SDHCI_DMA_ADDRESS, (u32)data->dest);
+		esdhc_write32(regs + SDHCI_DMA_ADDRESS, (u32)dest);
 		esdhc_write32(regs + SDHCI_BLOCK_SIZE__BLOCK_COUNT, data->blocks << 16 | SECTOR_SIZE);
 	}
 
-- 
2.17.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2018-06-06 18:45 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-06 18:43 [PATCH v3 00/38] ARM: i.MX8MQ and EVK support Andrey Smirnov
2018-06-06 18:43 ` Andrey Smirnov [this message]
2018-06-06 18:43 ` [PATCH v3 02/38] ARM: i.MX: compile arm32 specific errata only for CPU32 Andrey Smirnov
2018-06-06 18:43 ` [PATCH v3 03/38] ARM: Add i.MX8 support Andrey Smirnov
2018-06-06 18:43 ` [PATCH v3 04/38] aarch64: Add i.MX8 debug UART support Andrey Smirnov
2018-06-06 18:43 ` [PATCH v3 05/38] Include our own include/dt-bindings Andrey Smirnov
2018-06-06 18:43 ` [PATCH v3 06/38] mci: imx-esdhc: use dma mapping functions Andrey Smirnov
2018-06-06 18:44 ` [PATCH v3 07/38] net: fec_imx: remove unnecessary DMA sync ops Andrey Smirnov
2018-06-06 18:44 ` [PATCH v3 08/38] net: fec_imx: Use dma mapping functions Andrey Smirnov
2018-06-06 18:44 ` [PATCH v3 09/38] net: fec_imx: Make use of IS_ALIGNED Andrey Smirnov
2018-06-06 18:44 ` [PATCH v3 10/38] clock: Add i.MX8MQ clock driver Andrey Smirnov
2018-06-06 18:44 ` [PATCH v3 11/38] serial: i.MX: Add i.MX8 support Andrey Smirnov
2018-06-06 18:44 ` [PATCH v3 12/38] mmc: i.MX esdhc: " Andrey Smirnov
2018-06-06 18:44 ` [PATCH v3 13/38] gpio: i.MX: Add i.MX8mq support Andrey Smirnov
2018-06-06 18:44 ` [PATCH v3 14/38] ARM: i.MX: ocotp: Add i.MX8MQ support Andrey Smirnov
2018-06-06 18:44 ` [PATCH v3 15/38] ARM: i.MX: Split shared CCM code into a separate file Andrey Smirnov
2018-06-06 18:44 ` [PATCH v3 16/38] ARM: i.MX: Add IOMUX pad constants for i.MX8 Andrey Smirnov
2018-06-06 18:44 ` [PATCH v3 17/38] ARM: i.MX: Add basic CCM " Andrey Smirnov
2018-06-06 18:44 ` [PATCH v3 18/38] ARM: Add constants and helpers for system counter interface Andrey Smirnov
2018-06-06 18:44 ` [PATCH v3 19/38] clocksource: armv8-timer: Convert explicit assembly into helpers Andrey Smirnov
2018-06-06 18:44 ` [PATCH v3 20/38] ARM: i.MX8: Initialize system counter Andrey Smirnov
2018-06-06 18:44 ` [PATCH v3 21/38] ARM: i.MX: boot: Fix address casting on 64-bit platforms Andrey Smirnov
2018-06-06 18:44 ` [PATCH v3 22/38] ARM: boot: Add trivial i.MX8 support Andrey Smirnov
2018-06-06 18:44 ` [PATCH v3 23/38] ARM: i.MX: xload-esdhc: Rework to make code be less i.MX6-specific Andrey Smirnov
2018-06-06 18:44 ` [PATCH v3 24/38] ARM: i.MX: xload-esdhc: Allow custom buffer address, device offset Andrey Smirnov
2018-06-06 18:44 ` [PATCH v3 25/38] ARM: i.MX: xload-esdhc: Add support for i.MX8 Andrey Smirnov
2018-06-06 18:44 ` [PATCH v3 26/38] pinctrl: i.MX: " Andrey Smirnov
2018-06-06 18:44 ` [PATCH v3 27/38] Documentation: imx: Change block size for 'dd' to 1024 Andrey Smirnov
2018-06-06 18:44 ` [PATCH v3 28/38] Documentation: i.MX: Add missing <soctype> Andrey Smirnov
2018-06-06 18:44 ` [PATCH v3 29/38] clocksource: armv8-timer: Make armv8_clocksource_read() static Andrey Smirnov
2018-06-06 18:44 ` [PATCH v3 30/38] clocksource: armv8-timer: Make use of postcore_platform_driver() Andrey Smirnov
2018-06-06 18:44 ` [PATCH v3 31/38] Port <linux/iopoll.h> from U-Boot Andrey Smirnov
2018-06-06 18:44 ` [PATCH v3 32/38] common/clock: Move delay and timeout functions to clock.h Andrey Smirnov
2018-06-06 18:44 ` [PATCH v3 33/38] clock: Use udelay() to implement mdelay() Andrey Smirnov
2018-06-06 18:44 ` [PATCH v3 34/38] ARM: i.MX8: Add DDRC PHY and DDR CTL base addresses Andrey Smirnov
2018-06-06 18:44 ` [PATCH v3 35/38] Kbuild: Add $(quote) Andrey Smirnov
2018-06-06 18:44 ` [PATCH v3 36/38] Add builtin firmware support Andrey Smirnov
2018-06-06 18:44 ` [PATCH v3 37/38] ARM: i.MX8: Add DDRC PHY support code Andrey Smirnov
2018-06-06 18:44 ` [PATCH v3 38/38] ARM: Specify HAVE_PBL_IMAGE for CPU_64 Andrey Smirnov
2018-06-07 12:59 ` [PATCH v3 00/38] ARM: i.MX8MQ and EVK support Andrey Smirnov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180606184431.10348-2-andrew.smirnov@gmail.com \
    --to=andrew.smirnov@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox