From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/4] libfile: implement new helper write_file_flash()
Date: Fri, 8 Jun 2018 10:44:30 +0200 [thread overview]
Message-ID: <20180608084430.ojrdnn5oonfo3twb@pengutronix.de> (raw)
In-Reply-To: <20180608071044.d2zobfrrwkluuaei@pengutronix.de>
Hello Sascha,
On Fri, Jun 08, 2018 at 09:10:44AM +0200, Sascha Hauer wrote:
> On Thu, Jun 07, 2018 at 10:53:01PM +0200, Uwe Kleine-König wrote:
> > On Fri, Jun 01, 2018 at 08:07:48PM +0200, Uwe Kleine-König wrote:
> > > + fd = open(filename, O_WRONLY | O_TRUNC | O_CREAT);
> >
> > This doesn't work on the target machine (dove cubox) I intended to use
> > it on an m25p0 device. It returns -28. When dropping O_TRUNC | O_CREAT
> > it works though. So I suggest to either back out patches 3 and 4, or
> > change the line above to O_WRONLY (which also matches the function
> > removed in patch 4).
>
> Ok, changed to O_WRONLY only.
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2018-06-08 8:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-01 18:07 [PATCH 1/4] kwbimage_v0: add support to detect and boot a mvebu v0 image Uwe Kleine-König
2018-06-01 18:07 ` [PATCH 2/4] libfile: implement new helper write_file_flash() Uwe Kleine-König
2018-06-07 20:53 ` Uwe Kleine-König
2018-06-08 7:10 ` Sascha Hauer
2018-06-08 8:44 ` Uwe Kleine-König [this message]
2018-06-01 18:07 ` [PATCH 3/4] omap/am33xx_bbu: use file_write_flash() instead of its own variant Uwe Kleine-König
2018-06-01 18:07 ` [PATCH 4/4] scripts/kwboot: fix image check for v0 images Uwe Kleine-König
2018-06-04 7:01 ` [PATCH 1/4] kwbimage_v0: add support to detect and boot a mvebu v0 image Sascha Hauer
2018-06-04 7:02 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180608084430.ojrdnn5oonfo3twb@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox