From: Sascha Hauer <s.hauer@pengutronix.de>
To: Pascal Vizeli <pascal.vizeli@syshack.ch>
Cc: barebox@lists.infradead.org, Pascal Vizeli <pvizeli@syshack.ch>
Subject: Re: [PATCH 1/1] drivers: of: bugfix partition fixups
Date: Mon, 11 Jun 2018 08:41:39 +0200 [thread overview]
Message-ID: <20180611064139.tadrdsen76zhcq6e@pengutronix.de> (raw)
In-Reply-To: <CACvFaDf3ivn2jQxTKdT1b1VbzhnxdEXGojd4-8pVyiSz=rcvuw@mail.gmail.com>
On Fri, Jun 08, 2018 at 09:31:24AM +0200, Pascal Vizeli wrote:
> 2018-06-08 9:05 GMT+02:00 Sascha Hauer <s.hauer@pengutronix.de>:
> > of_find_property is not called directly from the code you are changing,
> > so how excatly is the code path that fails?
>
> of_get_reproducible_name -> of_get_property -> of_find_property
>
> >
> > What are you doing to get into this situation? This test should never
> > fail or else we are in trouble. Is there some "oftree -f" command
> > involved? I should really remove this command since in a device tree
> > based system there are always references to device nodes which are not
> > expected to become invalid.
> >
>
> Yes, I load the device tree from first bootloader and overlay some state dtbo.
> But how I should do this without flush? I can do that also an a file
> and load this
> to bootm, but the fixups will also run on this and fails too.
>
> I think we need remove `oftree -f` or apply this patch for hardening.
Just sent a patch for the former as the latter is a goal we do not seem
to reach.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2018-06-11 6:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-07 17:40 Pascal Vizeli
2018-06-08 7:05 ` Sascha Hauer
2018-06-08 7:31 ` Pascal Vizeli
2018-06-11 6:41 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180611064139.tadrdsen76zhcq6e@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=pascal.vizeli@syshack.ch \
--cc=pvizeli@syshack.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox