From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] mvebu: create bbu handler for kwb images and use it on cubox
Date: Mon, 11 Jun 2018 22:38:22 +0200 [thread overview]
Message-ID: <20180611203822.dpc6qtgvydg66veg@pengutronix.de> (raw)
In-Reply-To: <20180608084244.12816-1-u.kleine-koenig@pengutronix.de>
On Fri, Jun 08, 2018 at 10:42:44AM +0200, Uwe Kleine-König wrote:
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Hello,
>
> together with the fixup for write_file_flash to not use O_TRUNC and
> O_CREAT, this was tested on top of next.
>
> Best regards
> Uwe
>
> arch/arm/boards/solidrun-cubox/board.c | 15 ++++++-
> arch/arm/mach-mvebu/Makefile | 1 +
> arch/arm/mach-mvebu/include/mach/bbu.h | 3 ++
> arch/arm/mach-mvebu/kwb_bbu.c | 54 ++++++++++++++++++++++++++
> 4 files changed, 72 insertions(+), 1 deletion(-)
> create mode 100644 arch/arm/mach-mvebu/include/mach/bbu.h
> create mode 100644 arch/arm/mach-mvebu/kwb_bbu.c
>
> diff --git a/arch/arm/boards/solidrun-cubox/board.c b/arch/arm/boards/solidrun-cubox/board.c
> index a28f4197dfd4..aac93afb0c89 100644
> --- a/arch/arm/boards/solidrun-cubox/board.c
> +++ b/arch/arm/boards/solidrun-cubox/board.c
> @@ -14,4 +14,17 @@
> *
> */
>
> -/* empty */
> +#include <common.h>
> +#include <init.h>
> +#include <mach/bbu.h>
> +
> +static int cubox_devices_init(void)
> +{
> + if (!of_machine_is_compatible("solidrun,cubox"))
> + return 0;
> +
> + mvebu_bbu_flash_register_handler("flash", "/dev/m25p0", 0, true);
This breaks linking when bbu support is disabled. You'll have to
provide some static inline wrapper for this case.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2018-06-11 20:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-08 8:42 Uwe Kleine-König
2018-06-11 6:43 ` Sascha Hauer
2018-06-11 6:49 ` Uwe Kleine-König
2018-06-11 6:58 ` Sascha Hauer
2018-06-11 20:38 ` Sascha Hauer [this message]
2018-06-12 5:42 ` [PATCH] fixup! " Uwe Kleine-König
2018-06-13 8:28 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180611203822.dpc6qtgvydg66veg@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox