mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Alexander Kurz <akurz@blala.de>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH] commands: oftree: kill oftree -f
Date: Mon, 11 Jun 2018 22:44:20 +0200	[thread overview]
Message-ID: <20180611204420.ximo5tp7jv5g4444@pengutronix.de> (raw)
In-Reply-To: <alpine.DEB.2.20.1806111811470.16589@blala.de>

On Mon, Jun 11, 2018 at 06:35:48PM +0000, Alexander Kurz wrote:
> Hi Sascha,
> On Mon, 11 Jun 2018, Sascha Hauer wrote:
> 
> > Being able to free the live device tree seemed like a good idea in the
> > early days of device tree support when the first boards were brought up.
> > It turned out to be illusory that noone stores pointers to the live tree
> > which become invalid when oftree -f is executed. Enough people stumbled
> > upon crashed boards with this option, so remove it finally.
> 
> oftree -f is still in use in boot scripts, e.g. for the kindle-mx50,
> and at least one other board.
> The usecase for the kindle-mx50 is
> * DT based barebox
> * ATAGs dependent antiquated, non upgradeable kernel
> 
> start_linux() (arch/arm/lib32/armlinux.c) wont do setup_tags() if there
> still exists an oftree.
> If there is an alternative way to make boot issue 
> ATAGs, removing the -f option would be fine.
> 
> May I mention an old (rejected) proposal about this issue
> http://lists.infradead.org/pipermail/barebox/2016-December/028633.html
> 
> Also note: it's still in Documentation/user/devicetree.rst

Thanks for noting. I was a bit enthusiastic that I finally found the
energy to kill this option and forgot why I haven't done it earlier ;)
I just sent an updated series which should solve the issue of being able
to do a ATAG boot.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2018-06-11 20:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-11  6:41 Sascha Hauer
2018-06-11 18:35 ` Alexander Kurz
2018-06-11 20:44   ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180611204420.ximo5tp7jv5g4444@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=akurz@blala.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox