From: Sascha Hauer <s.hauer@pengutronix.de>
To: David Jander <david@protonic.nl>
Cc: Fabio Estevam <fabio.estevam@nxp.com>,
Barebox List <barebox@lists.infradead.org>,
Marco Franchi <marco.franchi@nxp.com>,
Shawn Guo <shawnguo@kernel.org>
Subject: Re: Device-tree node renames break barebox/kernel compatibility...
Date: Tue, 12 Jun 2018 14:47:38 +0200 [thread overview]
Message-ID: <20180612124738.pi66gx2vlgvoljmo@pengutronix.de> (raw)
In-Reply-To: <20180612142308.4a048a14@erd980>
Hi David,
On Tue, Jun 12, 2018 at 02:23:08PM +0200, David Jander wrote:
>
> Hi Sascha,
>
> I know this is old already, and I was surprised that I couldn't find any
> complaints about this yet, but I recently came across this patch in the kernel:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/patch/?id=df5cc9d0b42d15fa33b30440cca7a11ca7ba35a4
>
> ...which was adopted in barebox as this:
>
> https://git.pengutronix.de/cgit/barebox/patch/dts/src/arm/imx6qdl.dtsi?id=2e9cce8fb1f577088e2b20ae2f461130e13ad190
>
> As I don't know the exact reason as to why this was necessary, or why this is
> an issue at all, I just wanted to point out the fact that this leads to some
> breakage in barebox new and old.
This issue is known and has led to
https://www.mail-archive.com/barebox@lists.infradead.org/msg25189.html
>
> The specific problem I observed is here:
> https://git.pengutronix.de/cgit/barebox/tree/net/eth.c#n299
of_get_reproducible_name()/of_find_node_by_reproducible_name() is used for
fixing up mtd partitions and state nodes, but not yet for the ethernet
devices because nobody noticed.
To fix you would have to get a reproducible name of the ethernet device
node from the barebox device tree using of_find_node_by_reproducible_name()
and then use of_find_node_by_reproducible_name() on the kernel device
tree.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2018-06-12 12:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-12 12:23 David Jander
2018-06-12 12:47 ` Sascha Hauer [this message]
2018-06-12 13:46 ` David Jander
2018-06-13 6:42 ` Sascha Hauer
2018-06-13 6:50 ` David Jander
2018-06-13 16:57 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180612124738.pi66gx2vlgvoljmo@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=david@protonic.nl \
--cc=fabio.estevam@nxp.com \
--cc=marco.franchi@nxp.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox