From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-pg0-x244.google.com ([2607:f8b0:400e:c05::244]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fSqJH-0001xa-0W for barebox@lists.infradead.org; Tue, 12 Jun 2018 20:55:08 +0000 Received: by mail-pg0-x244.google.com with SMTP id 15-v6so146936pge.2 for ; Tue, 12 Jun 2018 13:54:24 -0700 (PDT) From: Andrey Smirnov Date: Tue, 12 Jun 2018 13:53:04 -0700 Message-Id: <20180612205310.25745-49-andrew.smirnov@gmail.com> In-Reply-To: <20180612205310.25745-1-andrew.smirnov@gmail.com> References: <20180612205310.25745-1-andrew.smirnov@gmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: [PATCH v5 48/54] scripts: imx-image: Drop error return from write_dcd() To: barebox@lists.infradead.org Cc: Andrey Smirnov Write_dcd() exits early in case of failure, so there's no realy reason to have it return a error code as a result. Drop it and simplify the caller code. Signed-off-by: Andrey Smirnov --- scripts/imx/imx-image.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/scripts/imx/imx-image.c b/scripts/imx/imx-image.c index b241e8c4b..a8a26e0ee 100644 --- a/scripts/imx/imx-image.c +++ b/scripts/imx/imx-image.c @@ -427,7 +427,7 @@ static int xwrite(int fd, void *buf, int len) return 0; } -static int write_dcd(const char *outfile) +static void write_dcd(const char *outfile) { int outfd, ret; int dcdsize = curdcd * sizeof(uint32_t); @@ -443,8 +443,6 @@ static int write_dcd(const char *outfile) perror("write"); exit(1); } - - return 0; } static int check(const struct config_data *data, uint32_t cmd, uint32_t addr, @@ -778,10 +776,8 @@ int main(int argc, char *argv[]) check_last_dcd(0); if (dcd_only) { - ret = write_dcd(data.outfile); - if (ret) - exit(1); - exit (0); + write_dcd(data.outfile); + exit(0); } switch (data.header_version) { -- 2.17.0 _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox