mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] ARM: i.MX: babbage: Make use of imx_setup_pad()
Date: Thu, 21 Jun 2018 12:55:43 +0200	[thread overview]
Message-ID: <20180621105543.yqaxsgpzz2blwphm@pengutronix.de> (raw)
In-Reply-To: <20180620005501.12891-1-andrew.smirnov@gmail.com>

On Tue, Jun 19, 2018 at 05:55:01PM -0700, Andrey Smirnov wrote:
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
>  arch/arm/boards/freescale-mx51-babbage/lowlevel.c | 11 ++---------
>  1 file changed, 2 insertions(+), 9 deletions(-)

Applied, thanks

Sascha

> 
> diff --git a/arch/arm/boards/freescale-mx51-babbage/lowlevel.c b/arch/arm/boards/freescale-mx51-babbage/lowlevel.c
> index 1c20b6a7a..216576ca2 100644
> --- a/arch/arm/boards/freescale-mx51-babbage/lowlevel.c
> +++ b/arch/arm/boards/freescale-mx51-babbage/lowlevel.c
> @@ -1,5 +1,6 @@
>  #include <debug_ll.h>
>  #include <mach/clock-imx51_53.h>
> +#include <mach/iomux-mx51.h>
>  #include <common.h>
>  #include <mach/esdctl.h>
>  #include <mach/generic.h>
> @@ -22,15 +23,7 @@ static inline void setup_uart(void)
>  	writel(MX5_CCM_CSCMR1_RESET_VALUE, ccmbase + MX5_CCM_CSCMR1);
>  	writel(MX5_CCM_CSCDR1_RESET_VALUE, ccmbase + MX5_CCM_CSCDR1);
>  
> -	/*
> -	 * The code below should be more or less a "moral equivalent"
> -	 * of:
> -	 *	 MX51_PAD_UART1_TXD__UART1_TXD 0x1c5
> -	 *
> -	 * in device tree
> -	 */
> -	writel(0x00000000, iomuxbase + 0x022c);
> -	writel(0x000001c5, iomuxbase + 0x061c);
> +	imx_setup_pad(iomuxbase, MX51_PAD_UART1_TXD__UART1_TXD);
>  
>  	imx51_uart_setup_ll();
>  
> -- 
> 2.17.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2018-06-21 10:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-20  0:55 Andrey Smirnov
2018-06-21 10:55 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180621105543.yqaxsgpzz2blwphm@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=andrew.smirnov@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox