From: Antony Pavlov <antonynpavlov@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 01/10] Add initial RISC-V architecture support
Date: Mon, 25 Jun 2018 09:46:04 +0300 [thread overview]
Message-ID: <20180625094604.29d353b8222da99c4e9a51d6@gmail.com> (raw)
In-Reply-To: <20180417062255.l62b3tldnqmydpjl@pengutronix.de>
On Tue, 17 Apr 2018 08:22:55 +0200
Sascha Hauer <s.hauer@pengutronix.de> wrote:
> Hi Antony,
>
> On Sun, Apr 15, 2018 at 02:28:49PM +0300, Antony Pavlov wrote:
> > Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> > ---
> > diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
> > new file mode 100644
> > index 0000000000..d65e87acd8
> > --- /dev/null
> > +++ b/arch/riscv/Kconfig
> > @@ -0,0 +1,62 @@
> > +config RISCV
> > + def_bool y
> > + select GENERIC_FIND_NEXT_BIT
> > + select HAVE_CONFIGURABLE_MEMORY_LAYOUT
> > + select HAVE_CONFIGURABLE_TEXT_BASE
> > + select GPIOLIB
> > + select OFTREE
> > + select COMMON_CLK
> > + select COMMON_CLK_OF_PROVIDER
> > + select CLKDEV_LOOKUP
> > +
> > +config ARCH_TEXT_BASE
> > + hex
> > + default 0x0
> > +
> > +config GENERIC_LINKER_SCRIPT
> > + def_bool y
>
> Do we need this? The linker script should be universal enough to be used
> by all boards.
I have dropped it in v2 RISC-V patchseries.
> > diff --git a/arch/riscv/dts/skeleton.dtsi b/arch/riscv/dts/skeleton.dtsi
> > new file mode 100644
> > index 0000000000..38ead821bb
> > --- /dev/null
> > +++ b/arch/riscv/dts/skeleton.dtsi
> > @@ -0,0 +1,13 @@
> > +/*
> > + * Skeleton device tree; the bare minimum needed to boot; just include and
> > + * add a compatible value. The bootloader will typically populate the memory
> > + * node.
> > + */
> > +
> > +/ {
> > + #address-cells = <2>;
> > + #size-cells = <1>;
> > + chosen { };
> > + aliases { };
> > + memory { device_type = "memory"; reg = <0 0 0>; };
> > +};
>
> skeleton.dtsi should no longer be used. For example we should now have
> memory@adr {}; instead of memory {};. Since "adr" is board/SoC specific
> we can't put it in a generic file.
I have dropped skeleton.dtsi in the v2 RISC-V patchseries.
I have even submitted patches for MIPS, please review.
>
> > diff --git a/arch/riscv/lib/ashldi3.c b/arch/riscv/lib/ashldi3.c
> > new file mode 100644
> > index 0000000000..cbdbcbb6a9
> > --- /dev/null
> > +++ b/arch/riscv/lib/ashldi3.c
> > @@ -0,0 +1,28 @@
> > +#include <module.h>
> > +
> > +#include "libgcc.h"
> > +
> > +long long __ashldi3(long long u, word_type b)
> > +{
>
> Can we have generic C variants for these files? The Kernel has these
> symbols in lib/ and they can be selected by "select GENERIC_ASHLDI3"
I know about this problem. I have even made a patch for linux kernel for MIPS:
[PATCH v3 2/2] MIPS: use generic GCC library routines from lib/
https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1599191.html
During this MIPS patch discussion it has become evident that Kconfig GENERIC_
prefix has to be changed to GENERIC_LIB_.
This morning I found that the patch
[PATCH] lib: Rename compiler intrinsic selects to GENERIC_LIB_*
https://patchwork.kernel.org/patch/10335017/
has been merged by Linus almost two weeks ago.
So I can prepare corresponding generic GCC functions barebox patchseries
(it will be useful for MIPS). Next I shall submit RISC-V v2 patchseries.
RISC-V will use generic GCC functions from lib/ too.
--
Best regards,
Antony Pavlov
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2018-06-25 6:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-15 11:28 [PATCH 00/10] " Antony Pavlov
2018-04-15 11:28 ` [PATCH 01/10] " Antony Pavlov
2018-04-17 6:22 ` Sascha Hauer
2018-06-25 6:46 ` Antony Pavlov [this message]
2018-04-15 11:28 ` [PATCH 02/10] RISC-V: add Erizo SoC support Antony Pavlov
2018-04-17 6:30 ` Sascha Hauer
2018-04-15 11:28 ` [PATCH 03/10] RISC-V: add low-level debug macros for ns16550 Antony Pavlov
2018-04-15 11:28 ` [PATCH 04/10] RISC-V: add nmon nano-monitor Antony Pavlov
2018-04-15 11:28 ` [PATCH 05/10] RISC-V: erizo: add DEBUG_LL support Antony Pavlov
2018-04-15 11:28 ` [PATCH 06/10] RISC-V: erizo: enable NMON Antony Pavlov
2018-04-15 11:28 ` [PATCH 07/10] RISC-V: erizo: add nmon image creation Antony Pavlov
2018-04-17 6:34 ` Sascha Hauer
2018-04-15 11:28 ` [PATCH 08/10] RISC-V: add erizo_generic_defconfig Antony Pavlov
2018-04-15 11:28 ` [PATCH 09/10] scripts: add nmon-loader Antony Pavlov
2018-04-15 11:28 ` [PATCH 10/10] Documentation: add RISC-V docs Antony Pavlov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180625094604.29d353b8222da99c4e9a51d6@gmail.com \
--to=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox