* [PATCH] ARM: imx6qp: fix NoC QoS passthrough for new cpu type functions.
@ 2018-06-28 16:29 Philipp Zabel
2018-06-29 12:47 ` Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Philipp Zabel @ 2018-06-28 16:29 UTC (permalink / raw)
To: barebox
On i.MX6QP/DP cpu_mx6_is_mx6q/d do not return true anymore.
Use the new cpu_mx6_is_mx6qp/dp to reenable NoC regulator bypass.
Fixes: d4c05d29d484 ("ARM: i.MX6: Add cpu type for 'plus' variants")
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
arch/arm/mach-imx/imx6.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/arm/mach-imx/imx6.c b/arch/arm/mach-imx/imx6.c
index eaf9f2e4130e..3d95c9e3749c 100644
--- a/arch/arm/mach-imx/imx6.c
+++ b/arch/arm/mach-imx/imx6.c
@@ -140,8 +140,7 @@ static void imx6_setup_ipu_qos(void)
* On i.MX6 QP/DP the NoC regulator for the IPU ports needs to be in
* bypass mode for the above settings to take effect.
*/
- if ((cpu_mx6_is_mx6q() || cpu_mx6_is_mx6d()) &&
- imx_silicon_revision() >= IMX_CHIP_REV_2_0) {
+ if (cpu_mx6_is_mx6qp() || cpu_mx6_is_mx6dp()) {
writel(0x2, fast2 + 0xb048c);
writel(0x2, fast2 + 0xb050c);
}
--
2.17.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: imx6qp: fix NoC QoS passthrough for new cpu type functions.
2018-06-28 16:29 [PATCH] ARM: imx6qp: fix NoC QoS passthrough for new cpu type functions Philipp Zabel
@ 2018-06-29 12:47 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2018-06-29 12:47 UTC (permalink / raw)
To: Philipp Zabel; +Cc: barebox
On Thu, Jun 28, 2018 at 06:29:05PM +0200, Philipp Zabel wrote:
> On i.MX6QP/DP cpu_mx6_is_mx6q/d do not return true anymore.
> Use the new cpu_mx6_is_mx6qp/dp to reenable NoC regulator bypass.
>
> Fixes: d4c05d29d484 ("ARM: i.MX6: Add cpu type for 'plus' variants")
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
> arch/arm/mach-imx/imx6.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
Applied, thanks
Sascha
> diff --git a/arch/arm/mach-imx/imx6.c b/arch/arm/mach-imx/imx6.c
> index eaf9f2e4130e..3d95c9e3749c 100644
> --- a/arch/arm/mach-imx/imx6.c
> +++ b/arch/arm/mach-imx/imx6.c
> @@ -140,8 +140,7 @@ static void imx6_setup_ipu_qos(void)
> * On i.MX6 QP/DP the NoC regulator for the IPU ports needs to be in
> * bypass mode for the above settings to take effect.
> */
> - if ((cpu_mx6_is_mx6q() || cpu_mx6_is_mx6d()) &&
> - imx_silicon_revision() >= IMX_CHIP_REV_2_0) {
> + if (cpu_mx6_is_mx6qp() || cpu_mx6_is_mx6dp()) {
> writel(0x2, fast2 + 0xb048c);
> writel(0x2, fast2 + 0xb050c);
> }
> --
> 2.17.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-06-29 12:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-28 16:29 [PATCH] ARM: imx6qp: fix NoC QoS passthrough for new cpu type functions Philipp Zabel
2018-06-29 12:47 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox