[PATCH] fixup! ARM: i.MX: Add support for ZII RDU1 board

[PATCH] fixup! ARM: i.MX: Add support for ZII RDU1 board

[Andrey Smirnov]

---

Sascha:

I tested "ARM: i.MX: Add support for ZII RDU1 board" patch as it is in
"next" and it works as expected. Here's a couple of cosmetic fixes I'd
suggest (feel free to ignore):

    - Drop all ZII_RDU1_DATAFLASH_* constants since now they are
      superfluous. Previous version of the patch used that string
      multiple time so it made more sense to have it as a named
      constant back then.

    - Avoid line wrap for IMX_BBU_FLAG_PARTITION_STARTS_AT_HEADER. 80
      character per line rule is still true on my 13" laptop when
      splitting screen in two and editing two files in parallel (what
      I end up doing 90% of the time)

Thanks,
Andrey Smirnov

 arch/arm/boards/zii-imx51-rdu1/board.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/arch/arm/boards/zii-imx51-rdu1/board.c b/arch/arm/boards/zii-imx51-rdu1/board.c
index edae99539..ac5232e17 100644
--- a/arch/arm/boards/zii-imx51-rdu1/board.c
+++ b/arch/arm/boards/zii-imx51-rdu1/board.c
@@ -21,9 +21,6 @@
 #include <libfile.h>
 #include <mach/imx5.h>
 
-#define ZII_RDU1_DATAFLASH		"/dev/dataflash0"
-#define ZII_RDU1_DATAFLASH_BAREBOX	ZII_RDU1_DATAFLASH ".barebox"
-
 static int zii_rdu1_init(void)
 {
 	if (!of_machine_is_compatible("zii,imx51-rdu1"))
@@ -35,8 +32,9 @@ static int zii_rdu1_init(void)
 
 	imx51_bbu_internal_mmc_register_handler("mmc", "/dev/mmc0", 0);
 	imx51_bbu_internal_spi_i2c_register_handler("spi",
-		ZII_RDU1_DATAFLASH_BAREBOX,
-		BBU_HANDLER_FLAG_DEFAULT | IMX_BBU_FLAG_PARTITION_STARTS_AT_HEADER);
+		"/dev/dataflash0.barebox",
+		BBU_HANDLER_FLAG_DEFAULT |
+		IMX_BBU_FLAG_PARTITION_STARTS_AT_HEADER);
 
 	return 0;
 }
-- 
2.17.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] fixup! ARM: i.MX: Add support for ZII RDU1 board

[Sascha Hauer]

On Fri, Jun 29, 2018 at 08:45:58PM -0700, Andrey Smirnov wrote:
> ---
> 
> Sascha:
> 
> I tested "ARM: i.MX: Add support for ZII RDU1 board" patch as it is in
> "next" and it works as expected. Here's a couple of cosmetic fixes I'd
> suggest (feel free to ignore):
> 
>     - Drop all ZII_RDU1_DATAFLASH_* constants since now they are
>       superfluous. Previous version of the patch used that string
>       multiple time so it made more sense to have it as a named
>       constant back then.
> 
>     - Avoid line wrap for IMX_BBU_FLAG_PARTITION_STARTS_AT_HEADER. 80
>       character per line rule is still true on my 13" laptop when
>       splitting screen in two and editing two files in parallel (what
>       I end up doing 90% of the time)
> 
> Thanks,
> Andrey Smirnov

Applied, thanks

Sascha

> 
>  arch/arm/boards/zii-imx51-rdu1/board.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm/boards/zii-imx51-rdu1/board.c b/arch/arm/boards/zii-imx51-rdu1/board.c
> index edae99539..ac5232e17 100644
> --- a/arch/arm/boards/zii-imx51-rdu1/board.c
> +++ b/arch/arm/boards/zii-imx51-rdu1/board.c
> @@ -21,9 +21,6 @@
>  #include <libfile.h>
>  #include <mach/imx5.h>
>  
> -#define ZII_RDU1_DATAFLASH		"/dev/dataflash0"
> -#define ZII_RDU1_DATAFLASH_BAREBOX	ZII_RDU1_DATAFLASH ".barebox"
> -
>  static int zii_rdu1_init(void)
>  {
>  	if (!of_machine_is_compatible("zii,imx51-rdu1"))
> @@ -35,8 +32,9 @@ static int zii_rdu1_init(void)
>  
>  	imx51_bbu_internal_mmc_register_handler("mmc", "/dev/mmc0", 0);
>  	imx51_bbu_internal_spi_i2c_register_handler("spi",
> -		ZII_RDU1_DATAFLASH_BAREBOX,
> -		BBU_HANDLER_FLAG_DEFAULT | IMX_BBU_FLAG_PARTITION_STARTS_AT_HEADER);
> +		"/dev/dataflash0.barebox",
> +		BBU_HANDLER_FLAG_DEFAULT |
> +		IMX_BBU_FLAG_PARTITION_STARTS_AT_HEADER);
>  
>  	return 0;
>  }
> -- 
> 2.17.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox