* [PATCH] reset: socfpga: add missing driver name
@ 2018-07-27 9:54 Steffen Trumtrar
2018-08-08 7:03 ` Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Steffen Trumtrar @ 2018-07-27 9:54 UTC (permalink / raw)
To: barebox; +Cc: Steffen Trumtrar
The driver_d is missing the name property. When the reset driver is used in a
non-of setup, this will result in an error during device_registration where
the dev->name is matched to the driver->name.
Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
---
drivers/reset/reset-socfpga.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/reset/reset-socfpga.c b/drivers/reset/reset-socfpga.c
index dd081ee84f72..b6faa0217ef2 100644
--- a/drivers/reset/reset-socfpga.c
+++ b/drivers/reset/reset-socfpga.c
@@ -113,6 +113,7 @@ static const struct of_device_id socfpga_reset_dt_ids[] = {
};
static struct driver_d socfpga_reset_driver = {
+ .name = "socfpga_reset",
.probe = socfpga_reset_probe,
.of_compatible = DRV_OF_COMPAT(socfpga_reset_dt_ids),
};
--
2.11.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] reset: socfpga: add missing driver name
2018-07-27 9:54 [PATCH] reset: socfpga: add missing driver name Steffen Trumtrar
@ 2018-08-08 7:03 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2018-08-08 7:03 UTC (permalink / raw)
To: Steffen Trumtrar; +Cc: barebox
On Fri, Jul 27, 2018 at 11:54:56AM +0200, Steffen Trumtrar wrote:
> The driver_d is missing the name property. When the reset driver is used in a
> non-of setup, this will result in an error during device_registration where
> the dev->name is matched to the driver->name.
>
> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> ---
> drivers/reset/reset-socfpga.c | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks
Sascha
>
> diff --git a/drivers/reset/reset-socfpga.c b/drivers/reset/reset-socfpga.c
> index dd081ee84f72..b6faa0217ef2 100644
> --- a/drivers/reset/reset-socfpga.c
> +++ b/drivers/reset/reset-socfpga.c
> @@ -113,6 +113,7 @@ static const struct of_device_id socfpga_reset_dt_ids[] = {
> };
>
> static struct driver_d socfpga_reset_driver = {
> + .name = "socfpga_reset",
> .probe = socfpga_reset_probe,
> .of_compatible = DRV_OF_COMPAT(socfpga_reset_dt_ids),
> };
> --
> 2.11.0
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-08 7:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-27 9:54 [PATCH] reset: socfpga: add missing driver name Steffen Trumtrar
2018-08-08 7:03 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox