[PATCH 1/4] ARM: i.MX: HAB: fix missing include for EPERM

[PATCH 1/4] ARM: i.MX: HAB: fix missing include for EPERM

[Roland Hieber]

Signed-off-by: Roland Hieber <r.hieber@pengutronix.de>
---
 include/hab.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/hab.h b/include/hab.h
index fb7149ef53..78c2b865ba 100644
--- a/include/hab.h
+++ b/include/hab.h
@@ -18,6 +18,8 @@
 #ifndef __HABV4_H
 #define __HABV4_H
 
+#include <errno.h>
+
 #ifdef CONFIG_HABV4
 int imx28_hab_get_status(void);
 int imx6_hab_get_status(void);
-- 
2.18.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 2/4] ARM: i.MX: OCOTP: fix missing include for uint32_t etc.

[Roland Hieber]

Signed-off-by: Roland Hieber <r.hieber@pengutronix.de>
---
 arch/arm/mach-imx/include/mach/ocotp.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-imx/include/mach/ocotp.h b/arch/arm/mach-imx/include/mach/ocotp.h
index 76a6da53de..e758238cb9 100644
--- a/arch/arm/mach-imx/include/mach/ocotp.h
+++ b/arch/arm/mach-imx/include/mach/ocotp.h
@@ -2,6 +2,7 @@
 #define __MACH_IMX_OCOTP_H
 
 #include <linux/bitfield.h>
+#include <linux/types.h>
 
 #define OCOTP_SHADOW_OFFSET		0x400
 #define OCOTP_SHADOW_SPACING		0x10
-- 
2.18.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 3/4] gpio: fix missing includes for bool and struct list_head

[Roland Hieber]

Signed-off-by: Roland Hieber <r.hieber@pengutronix.de>
---
 include/gpio.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/include/gpio.h b/include/gpio.h
index f5262aac42..e42fa23383 100644
--- a/include/gpio.h
+++ b/include/gpio.h
@@ -1,6 +1,9 @@
 #ifndef __GPIO_H
 #define __GPIO_H
 
+#include <linux/types.h>
+#include <linux/list.h>
+
 #ifdef CONFIG_GENERIC_GPIO
 void gpio_set_value(unsigned gpio, int value);
 int gpio_get_value(unsigned gpio);
-- 
2.18.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 4/4] linux/types.h: fix missing include for BITS_TO_LONGS()

[Roland Hieber]

Signed-off-by: Roland Hieber <r.hieber@pengutronix.de>
---
 include/linux/types.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/types.h b/include/linux/types.h
index f64ec4a814..44d8238d53 100644
--- a/include/linux/types.h
+++ b/include/linux/types.h
@@ -2,6 +2,7 @@
 #define _LINUX_TYPES_H
 
 #include <linux/posix_types.h>
+#include <linux/bitops.h>
 #include <asm/types.h>
 
 #define DECLARE_BITMAP(name,bits) \
-- 
2.18.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH 1/4] ARM: i.MX: HAB: fix missing include for EPERM

[Sascha Hauer]

On Mon, Jul 30, 2018 at 01:14:34PM +0200, Roland Hieber wrote:
> Signed-off-by: Roland Hieber <r.hieber@pengutronix.de>
> ---
>  include/hab.h | 2 ++
>  1 file changed, 2 insertions(+)

Applied, thanks

Sascha

> 
> diff --git a/include/hab.h b/include/hab.h
> index fb7149ef53..78c2b865ba 100644
> --- a/include/hab.h
> +++ b/include/hab.h
> @@ -18,6 +18,8 @@
>  #ifndef __HABV4_H
>  #define __HABV4_H
>  
> +#include <errno.h>
> +
>  #ifdef CONFIG_HABV4
>  int imx28_hab_get_status(void);
>  int imx6_hab_get_status(void);
> -- 
> 2.18.0
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH 4/4] linux/types.h: fix missing include for BITS_TO_LONGS()

[Sascha Hauer]

On Mon, Jul 30, 2018 at 01:14:37PM +0200, Roland Hieber wrote:
> Signed-off-by: Roland Hieber <r.hieber@pengutronix.de>
> ---
>  include/linux/types.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/types.h b/include/linux/types.h
> index f64ec4a814..44d8238d53 100644
> --- a/include/linux/types.h
> +++ b/include/linux/types.h
> @@ -2,6 +2,7 @@
>  #define _LINUX_TYPES_H
>  
>  #include <linux/posix_types.h>
> +#include <linux/bitops.h>
>  #include <asm/types.h>

This breaks compilation on ppc. Here linux/bitops.h includes files which
use types (__be32 and friends) which are declared later in
include/linux/types.h.

Why specifically is this patch needed?

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH 4/4] linux/types.h: fix missing include for BITS_TO_LONGS()

[Roland Hieber]

On Thu, Aug 09, 2018 at 09:38:39PM +0200, Sascha Hauer wrote:
> On Mon, Jul 30, 2018 at 01:14:37PM +0200, Roland Hieber wrote:
> > Signed-off-by: Roland Hieber <r.hieber@pengutronix.de>
> > ---
> >  include/linux/types.h | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/include/linux/types.h b/include/linux/types.h
> > index f64ec4a814..44d8238d53 100644
> > --- a/include/linux/types.h
> > +++ b/include/linux/types.h
> > @@ -2,6 +2,7 @@
> >  #define _LINUX_TYPES_H
> >  
> >  #include <linux/posix_types.h>
> > +#include <linux/bitops.h>
> >  #include <asm/types.h>
> 
> This breaks compilation on ppc. Here linux/bitops.h includes files which
> use types (__be32 and friends) which are declared later in
> include/linux/types.h.
> 
> Why specifically is this patch needed?

I was isolating the architecture-specific parts of a shared customer
code base into single files (in order to port it to another arch), and
in that process I ended up with a .c file that included <linux/types.h>
for some macro which I don't remember, but it did not compile because
<linux/types.h> declares macros that use BITS_TO_LONGS(), which is
declared in <linux/bitops.h>, which was not included before.
I guess the original code already included <linux/bitops.h> via some
other path before including <linux/types.h>, so the error did not happen
there. So I reasoned that if <linux/types.h> uses BITS_TO_LONGS(), it
should include the respective header where this macro is defined.

And now that you say it, I see that I should have written that in my
commit message.

 - Roland

-- 
Roland Hieber                     | r.hieber@pengutronix.de     |
Pengutronix e.K.                  | https://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim | Phone: +49-5121-206917-5086 |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox