mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Roland Hieber <r.hieber@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 04/13] ARM: MXS: allow configuration of EMI clock dividers
Date: Wed, 8 Aug 2018 08:41:51 +0200	[thread overview]
Message-ID: <20180808064151.mk5jhcl67pvze3x3@pengutronix.de> (raw)
In-Reply-To: <20180725133618.1510-5-r.hieber@pengutronix.de>

On Wed, Jul 25, 2018 at 03:36:09PM +0200, Roland Hieber wrote:
> For now, the clock dividers are only accessible from mx28_mem_init, and
> the old prescaler of 2 is hardcoded in mx23_mem_init. I'm not sure
> if it makes sense to change it at all.
> 
> Signed-off-by: Roland Hieber <r.hieber@pengutronix.de>
> ---
>  arch/arm/boards/duckbill/lowlevel.c           |  2 ++
>  arch/arm/boards/freescale-mx28-evk/lowlevel.c |  2 ++
>  arch/arm/boards/karo-tx28/lowlevel.c          |  2 ++
>  arch/arm/mach-mxs/include/mach/init.h         |  6 +++---
>  arch/arm/mach-mxs/mem-init.c                  | 16 ++++++++--------
>  5 files changed, 17 insertions(+), 11 deletions(-)
> 
> diff --git a/arch/arm/boards/duckbill/lowlevel.c b/arch/arm/boards/duckbill/lowlevel.c
> index 3adda68d77..393d4e1e12 100644
> --- a/arch/arm/boards/duckbill/lowlevel.c
> +++ b/arch/arm/boards/duckbill/lowlevel.c
> @@ -56,6 +56,8 @@ static noinline void duckbill_init(void)
>  	pr_debug("initializing SDRAM...\n");
>  
>  	mx28_mem_init(PINCTRL_EMI_DS_CTRL_DDR_MODE_DDR2,
> +			/* EMI_CLK of 480 / 2 * (18/21) = 205.7 MHz */
> +			2, 21,
>  			mx28_dram_vals_default);

Instead of adding more parameters to mx28_mem_init() I slighty prefer to
require the boards to call mxs_mem_init_clock() directly instead and
remove it from mx28_mem_init().

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2018-08-08  6:42 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-25 13:36 [PATCH 00/13] MXS/MX28 low-level improvements Roland Hieber
2018-07-25 13:36 ` [PATCH 01/13] scripts: mxsimage: Allow unencrypted images Roland Hieber
2018-07-25 13:36 ` [PATCH 02/13] images: MXS: allow generation of unencrypted bootstreams Roland Hieber
2018-07-25 13:36 ` [PATCH 03/13] ARM: MXS: i.MX28: allow setup of low-voltage SDRAM Roland Hieber
2018-07-25 13:36 ` [PATCH 04/13] ARM: MXS: allow configuration of EMI clock dividers Roland Hieber
2018-08-08  6:41   ` Sascha Hauer [this message]
2018-07-25 13:36 ` [PATCH 05/13] ARM: MXS: i.MX28: add autodetection of memory banks Roland Hieber
2018-07-27  8:28   ` Roland Hieber
2018-07-31 10:07   ` Roland Hieber
2018-08-08  6:40     ` Sascha Hauer
2018-07-25 13:36 ` [PATCH 06/13] ARM: MXS: refactor mx2*_power_init source configuration Roland Hieber
2018-07-25 13:36 ` [PATCH 07/13] ARM: MXS: allow starting from battery input without 4P2 source enabled Roland Hieber
2018-07-25 13:36 ` [PATCH 08/13] ARM: MXS: make power levels configurable in mx2*_power_init Roland Hieber
2018-07-25 13:36 ` [PATCH 09/13] ARM: MXS: fix VDDx brownout setup logic Roland Hieber
2018-07-25 13:36 ` [PATCH 10/13] ARM: MXS: make VDDx brownout setup more understandable Roland Hieber
2018-07-25 13:36 ` [PATCH 11/13] ARM: MXS: mxs_power_status: use less magic values Roland Hieber
2018-07-25 13:36 ` [PATCH 12/13] ARM: MXS: mxs_power_status: align output Roland Hieber
2018-07-25 13:36 ` [PATCH 13/13] Documentation: MXS: general update and improvements Roland Hieber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180808064151.mk5jhcl67pvze3x3@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=r.hieber@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox