mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/3] PCI: link PCI devices with potentially existing OF nodes
Date: Wed, 8 Aug 2018 09:28:17 +0200	[thread overview]
Message-ID: <20180808072817.qmxea4km7vbytvp3@pengutronix.de> (raw)
In-Reply-To: <20180801083831.12983-2-l.stach@pengutronix.de>

On Wed, Aug 01, 2018 at 10:38:29AM +0200, Lucas Stach wrote:
> The document "PCI Bus Binding to: IEEE Std 1275-1994 Standard for Boot
> (Initialization Configuration) Firmware" describes how the PCI topology
> can be described in the DT, in order to augment the PCI devices with
> additional information via DT properties.
> 
> This patch links OF nodes to the corresponding PCI devices if they
> exist, allowing PCI device drivers to query DT information like any
> platform device.
> 
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
>  drivers/pci/pci.c | 30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)

Applied, thanks

Sascha

> 
> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index b2570eb15181..bd8b7278ef19 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -331,6 +331,31 @@ static void postscan_setup_bridge(struct pci_dev *dev)
>  	}
>  }
>  
> +static struct device_node *
> +pci_of_match_device(struct device_d *parent, unsigned int devfn)
> +{
> +	struct device_node *np;
> +	u32 reg;
> +
> +	if (!IS_ENABLED(CONFIG_OFTREE) || !parent->device_node)
> +		return NULL;
> +
> +	for_each_child_of_node(parent->device_node, np) {
> +		if (!of_property_read_u32_array(np, "reg", &reg, 1)) {
> +			/*
> +			 * Only match device/function pair of the device
> +			 * address, other properties are defined by the
> +			 * PCI/OF node topology.
> +			 */
> +			reg = (reg >> 8) & 0xffff;
> +			if (reg == devfn)
> +				return np;
> +		}
> +	}
> +
> +	return NULL;
> +}
> +
>  unsigned int pci_scan_bus(struct pci_bus *bus)
>  {
>  	struct pci_dev *dev;
> @@ -368,6 +393,11 @@ unsigned int pci_scan_bus(struct pci_bus *bus)
>  		dev->vendor = l & 0xffff;
>  		dev->device = (l >> 16) & 0xffff;
>  		dev->dev.parent = bus->parent;
> +		dev->dev.device_node = pci_of_match_device(bus->parent, devfn);
> +		if (dev->dev.device_node)
> +			pr_debug("found DT node %s for device %04x:%04x\n",
> +				 dev->dev.device_node->full_name,
> +				 dev->vendor, dev->device);
>  
>  		/* non-destructively determine if device can be a master: */
>  		pci_read_config_byte(dev, PCI_COMMAND, &cmd);
> -- 
> 2.18.0
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2018-08-08  7:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-01  8:38 [PATCH] ARM: mmu: fix cache flushing when replacing a section with a PTE Lucas Stach
2018-08-01  8:38 ` [PATCH 1/3] PCI: link PCI devices with potentially existing OF nodes Lucas Stach
2018-08-08  7:28   ` Sascha Hauer [this message]
2018-08-01  8:38 ` [PATCH 2/3] pci: add quirk infrastructure Lucas Stach
2018-08-01  8:38 ` [PATCH 3/3] ARM: imx6: gw54xx: add fixup for PCIe switch Lucas Stach
2018-08-01  9:01 ` [PATCH] ARM: mmu: fix cache flushing when replacing a section with a PTE Lucas Stach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180808072817.qmxea4km7vbytvp3@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=l.stach@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox