mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: barebox@lists.infradead.org, Daniel Schultz <d.schultz@phytec.de>
Subject: Re: [PATCH] ARM: phytec-som-am335x: make autoenable actually usable
Date: Wed, 8 Aug 2018 09:33:05 +0200	[thread overview]
Message-ID: <20180808073305.gs2ne6ffwyl76vmf@pengutronix.de> (raw)
In-Reply-To: <20180807142116.26093-1-u.kleine-koenig@pengutronix.de>

On Tue, Aug 07, 2018 at 04:21:16PM +0200, Uwe Kleine-König wrote:
> IS_ENABLED has to be passed the full symbol name including the CONFIG_
> prefix. Otherwise IS_ENABLED evaluates to 0.
> 
> Fixes: 2877e08f9e1a ("ARM: phytec-som-am335x: Add autoenable")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> --
> Cc: Daniel Schultz <d.schultz@phytec.de>
> ---
>  arch/arm/boards/phytec-som-am335x/board.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks

Sascha

> 
> diff --git a/arch/arm/boards/phytec-som-am335x/board.c b/arch/arm/boards/phytec-som-am335x/board.c
> index 0e9bf5fdef88..8c24f2b33249 100644
> --- a/arch/arm/boards/phytec-som-am335x/board.c
> +++ b/arch/arm/boards/phytec-som-am335x/board.c
> @@ -135,7 +135,7 @@ static int physom_devices_init(void)
>  			}
>  	}
>  
> -	if (IS_ENABLED(PHYTEC_SOM_AM335X_OF_AUTOENABLE)) {
> +	if (IS_ENABLED(CONFIG_PHYTEC_SOM_AM335X_OF_AUTOENABLE)) {
>  		/* Enable NAND */
>  		of_autoenable_device_by_path("/ocp/gpmc@50000000");
>  		/* Enable eMMC */
> -- 
> 2.18.0
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2018-08-08  7:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-07 14:21 Uwe Kleine-König
2018-08-08  7:33 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180808073305.gs2ne6ffwyl76vmf@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=d.schultz@phytec.de \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox