mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] ARM: phytec-som-am335x: make autoenable actually usable
@ 2018-08-07 14:21 Uwe Kleine-König
  2018-08-08  7:33 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Uwe Kleine-König @ 2018-08-07 14:21 UTC (permalink / raw)
  To: barebox; +Cc: Daniel Schultz

IS_ENABLED has to be passed the full symbol name including the CONFIG_
prefix. Otherwise IS_ENABLED evaluates to 0.

Fixes: 2877e08f9e1a ("ARM: phytec-som-am335x: Add autoenable")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
--
Cc: Daniel Schultz <d.schultz@phytec.de>
---
 arch/arm/boards/phytec-som-am335x/board.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boards/phytec-som-am335x/board.c b/arch/arm/boards/phytec-som-am335x/board.c
index 0e9bf5fdef88..8c24f2b33249 100644
--- a/arch/arm/boards/phytec-som-am335x/board.c
+++ b/arch/arm/boards/phytec-som-am335x/board.c
@@ -135,7 +135,7 @@ static int physom_devices_init(void)
 			}
 	}
 
-	if (IS_ENABLED(PHYTEC_SOM_AM335X_OF_AUTOENABLE)) {
+	if (IS_ENABLED(CONFIG_PHYTEC_SOM_AM335X_OF_AUTOENABLE)) {
 		/* Enable NAND */
 		of_autoenable_device_by_path("/ocp/gpmc@50000000");
 		/* Enable eMMC */
-- 
2.18.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: phytec-som-am335x: make autoenable actually usable
  2018-08-07 14:21 [PATCH] ARM: phytec-som-am335x: make autoenable actually usable Uwe Kleine-König
@ 2018-08-08  7:33 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2018-08-08  7:33 UTC (permalink / raw)
  To: Uwe Kleine-König; +Cc: barebox, Daniel Schultz

On Tue, Aug 07, 2018 at 04:21:16PM +0200, Uwe Kleine-König wrote:
> IS_ENABLED has to be passed the full symbol name including the CONFIG_
> prefix. Otherwise IS_ENABLED evaluates to 0.
> 
> Fixes: 2877e08f9e1a ("ARM: phytec-som-am335x: Add autoenable")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> --
> Cc: Daniel Schultz <d.schultz@phytec.de>
> ---
>  arch/arm/boards/phytec-som-am335x/board.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks

Sascha

> 
> diff --git a/arch/arm/boards/phytec-som-am335x/board.c b/arch/arm/boards/phytec-som-am335x/board.c
> index 0e9bf5fdef88..8c24f2b33249 100644
> --- a/arch/arm/boards/phytec-som-am335x/board.c
> +++ b/arch/arm/boards/phytec-som-am335x/board.c
> @@ -135,7 +135,7 @@ static int physom_devices_init(void)
>  			}
>  	}
>  
> -	if (IS_ENABLED(PHYTEC_SOM_AM335X_OF_AUTOENABLE)) {
> +	if (IS_ENABLED(CONFIG_PHYTEC_SOM_AM335X_OF_AUTOENABLE)) {
>  		/* Enable NAND */
>  		of_autoenable_device_by_path("/ocp/gpmc@50000000");
>  		/* Enable eMMC */
> -- 
> 2.18.0
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-08-08  7:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-07 14:21 [PATCH] ARM: phytec-som-am335x: make autoenable actually usable Uwe Kleine-König
2018-08-08  7:33 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox