From: Sascha Hauer <s.hauer@pengutronix.de>
To: Fabio Estevam <festevam@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v2] mx5: Implement Spectre v2 workaround for Cortex-A8
Date: Wed, 8 Aug 2018 15:42:00 +0200 [thread overview]
Message-ID: <20180808134200.ackpfosj7ysktz5n@pengutronix.de> (raw)
In-Reply-To: <1531417503-11837-1-git-send-email-festevam@gmail.com>
On Thu, Jul 12, 2018 at 02:45:03PM -0300, Fabio Estevam wrote:
> Since 4.18-rc1 kernel the following warning is seen on i.MX51 and
> i.MX53:
>
> CPU0: Spectre v2: firmware did not set auxiliary control register IBE bit, system vulnerable
>
> Implement the suggested workaround by setting the IBE bit in the
> auxiliary control register, which allows the kernel to flush the
> BTB properly.
>
> Based on commit 7b37a9c732bf ("ARM: Introduce ability to enable ACR::IBE
> on Cortex-A8 for CVE-2017-5715") from U-Boot.
>
> With this patch applied the kernel now reports:
>
> CPU0: Spectre v2: using BPIALL workaround
>
> Tested on a imx51 babbage.
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
Applied, thanks
Sascha
> Changes since v1:
> - Rename the function name (Lucas)
> - Improve the commit log (Lucas)
>
> arch/arm/include/asm/errata.h | 9 +++++++++
> arch/arm/mach-imx/cpu_init.c | 3 ++-
> 2 files changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/include/asm/errata.h b/arch/arm/include/asm/errata.h
> index 98137b5..c0e0f5a 100644
> --- a/arch/arm/include/asm/errata.h
> +++ b/arch/arm/include/asm/errata.h
> @@ -86,3 +86,12 @@ static inline void enable_arm_errata_845369_war(void)
> "mcr p15, 0, r0, c15, c0, 1\n"
> );
> }
> +
> +static inline void enable_arm_errata_cortexa8_enable_ibe(void)
> +{
> + __asm__ __volatile__ (
> + "mrc p15, 0, r0, c1, c0, 1\n"
> + "orr r0, r0, #1 << 6\n"
> + "mcr p15, 0, r0, c1, c0, 1\n"
> + );
> +}
> diff --git a/arch/arm/mach-imx/cpu_init.c b/arch/arm/mach-imx/cpu_init.c
> index 5b93d12..e1d88c7 100644
> --- a/arch/arm/mach-imx/cpu_init.c
> +++ b/arch/arm/mach-imx/cpu_init.c
> @@ -22,6 +22,7 @@ void imx5_cpu_lowlevel_init(void)
> arm_cpu_lowlevel_init();
>
> enable_arm_errata_709718_war();
> + enable_arm_errata_cortexa8_enable_ibe();
> }
>
> void imx6_cpu_lowlevel_init(void)
> @@ -51,4 +52,4 @@ void vf610_cpu_lowlevel_init(void)
> {
> arm_cpu_lowlevel_init();
> }
> -#endif
> \ No newline at end of file
> +#endif
> --
> 2.7.4
>
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2018-08-08 13:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-12 17:45 Fabio Estevam
2018-07-13 10:28 ` Lucas Stach
2018-08-08 13:42 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180808134200.ackpfosj7ysktz5n@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=festevam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox