* [PATCH 1/2] ARM: VFxxx: zii-vf610-dev: Add newline before error banner
@ 2018-08-09 22:52 Andrey Smirnov
2018-08-09 22:52 ` [PATCH 2/2] ARM: VFxxx: zii-vf610-dev: Make get_sytem_type() static Andrey Smirnov
2018-08-10 6:43 ` [PATCH 1/2] ARM: VFxxx: zii-vf610-dev: Add newline before error banner Sascha Hauer
0 siblings, 2 replies; 3+ messages in thread
From: Andrey Smirnov @ 2018-08-09 22:52 UTC (permalink / raw)
To: barebox; +Cc: Andrey Smirnov
Add a cosmetic newline to the beginning of the error banner printed
when we encounter unidentified board type. This way we'd avoid
artifacts like:
barebox@ZII RDU1 Board:/ >*********************************
* Unknown system type: 00000004
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
arch/arm/boards/zii-vf610-dev/lowlevel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boards/zii-vf610-dev/lowlevel.c b/arch/arm/boards/zii-vf610-dev/lowlevel.c
index f3d67501a..d2f30d7ab 100644
--- a/arch/arm/boards/zii-vf610-dev/lowlevel.c
+++ b/arch/arm/boards/zii-vf610-dev/lowlevel.c
@@ -111,7 +111,7 @@ ENTRY_FUNCTION(start_zii_vf610_dev, r0, r1, r2)
if (IS_ENABLED(CONFIG_DEBUG_LL)) {
relocate_to_current_adr();
setup_c();
- puts_ll("*********************************\n");
+ puts_ll("\n*********************************\n");
puts_ll("* Unknown system type: ");
puthex_ll(system_type);
puts_ll("\n* Assuming devboard revision B\n");
--
2.17.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH 2/2] ARM: VFxxx: zii-vf610-dev: Make get_sytem_type() static
2018-08-09 22:52 [PATCH 1/2] ARM: VFxxx: zii-vf610-dev: Add newline before error banner Andrey Smirnov
@ 2018-08-09 22:52 ` Andrey Smirnov
2018-08-10 6:43 ` [PATCH 1/2] ARM: VFxxx: zii-vf610-dev: Add newline before error banner Sascha Hauer
1 sibling, 0 replies; 3+ messages in thread
From: Andrey Smirnov @ 2018-08-09 22:52 UTC (permalink / raw)
To: barebox; +Cc: Andrey Smirnov
There's no reason for that function to be non-static, so convert it.
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
arch/arm/boards/zii-vf610-dev/lowlevel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boards/zii-vf610-dev/lowlevel.c b/arch/arm/boards/zii-vf610-dev/lowlevel.c
index d2f30d7ab..c771d81cc 100644
--- a/arch/arm/boards/zii-vf610-dev/lowlevel.c
+++ b/arch/arm/boards/zii-vf610-dev/lowlevel.c
@@ -43,7 +43,7 @@ enum zii_platform_vf610_type {
ZII_PLATFORM_VF610_DEV_REV_C = 0x05,
};
-unsigned int get_system_type(void)
+static unsigned int get_system_type(void)
{
#define GPIO_PDIR 0x10
--
2.17.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 1/2] ARM: VFxxx: zii-vf610-dev: Add newline before error banner
2018-08-09 22:52 [PATCH 1/2] ARM: VFxxx: zii-vf610-dev: Add newline before error banner Andrey Smirnov
2018-08-09 22:52 ` [PATCH 2/2] ARM: VFxxx: zii-vf610-dev: Make get_sytem_type() static Andrey Smirnov
@ 2018-08-10 6:43 ` Sascha Hauer
1 sibling, 0 replies; 3+ messages in thread
From: Sascha Hauer @ 2018-08-10 6:43 UTC (permalink / raw)
To: Andrey Smirnov; +Cc: barebox
On Thu, Aug 09, 2018 at 03:52:29PM -0700, Andrey Smirnov wrote:
> Add a cosmetic newline to the beginning of the error banner printed
> when we encounter unidentified board type. This way we'd avoid
> artifacts like:
>
> barebox@ZII RDU1 Board:/ >*********************************
> * Unknown system type: 00000004
>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
Applied, thanks
Sascha
> arch/arm/boards/zii-vf610-dev/lowlevel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boards/zii-vf610-dev/lowlevel.c b/arch/arm/boards/zii-vf610-dev/lowlevel.c
> index f3d67501a..d2f30d7ab 100644
> --- a/arch/arm/boards/zii-vf610-dev/lowlevel.c
> +++ b/arch/arm/boards/zii-vf610-dev/lowlevel.c
> @@ -111,7 +111,7 @@ ENTRY_FUNCTION(start_zii_vf610_dev, r0, r1, r2)
> if (IS_ENABLED(CONFIG_DEBUG_LL)) {
> relocate_to_current_adr();
> setup_c();
> - puts_ll("*********************************\n");
> + puts_ll("\n*********************************\n");
> puts_ll("* Unknown system type: ");
> puthex_ll(system_type);
> puts_ll("\n* Assuming devboard revision B\n");
> --
> 2.17.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-10 6:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-09 22:52 [PATCH 1/2] ARM: VFxxx: zii-vf610-dev: Add newline before error banner Andrey Smirnov
2018-08-09 22:52 ` [PATCH 2/2] ARM: VFxxx: zii-vf610-dev: Make get_sytem_type() static Andrey Smirnov
2018-08-10 6:43 ` [PATCH 1/2] ARM: VFxxx: zii-vf610-dev: Add newline before error banner Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox