From: Sascha Hauer <s.hauer@pengutronix.de>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/2] ARM: VFxxx: zii-vf610-dev: Add newline before error banner
Date: Fri, 10 Aug 2018 08:43:03 +0200 [thread overview]
Message-ID: <20180810064303.c4dulds6qib2athq@pengutronix.de> (raw)
In-Reply-To: <20180809225230.21989-1-andrew.smirnov@gmail.com>
On Thu, Aug 09, 2018 at 03:52:29PM -0700, Andrey Smirnov wrote:
> Add a cosmetic newline to the beginning of the error banner printed
> when we encounter unidentified board type. This way we'd avoid
> artifacts like:
>
> barebox@ZII RDU1 Board:/ >*********************************
> * Unknown system type: 00000004
>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
Applied, thanks
Sascha
> arch/arm/boards/zii-vf610-dev/lowlevel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boards/zii-vf610-dev/lowlevel.c b/arch/arm/boards/zii-vf610-dev/lowlevel.c
> index f3d67501a..d2f30d7ab 100644
> --- a/arch/arm/boards/zii-vf610-dev/lowlevel.c
> +++ b/arch/arm/boards/zii-vf610-dev/lowlevel.c
> @@ -111,7 +111,7 @@ ENTRY_FUNCTION(start_zii_vf610_dev, r0, r1, r2)
> if (IS_ENABLED(CONFIG_DEBUG_LL)) {
> relocate_to_current_adr();
> setup_c();
> - puts_ll("*********************************\n");
> + puts_ll("\n*********************************\n");
> puts_ll("* Unknown system type: ");
> puthex_ll(system_type);
> puts_ll("\n* Assuming devboard revision B\n");
> --
> 2.17.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2018-08-10 6:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-09 22:52 Andrey Smirnov
2018-08-09 22:52 ` [PATCH 2/2] ARM: VFxxx: zii-vf610-dev: Make get_sytem_type() static Andrey Smirnov
2018-08-10 6:43 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180810064303.c4dulds6qib2athq@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox