mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] i.MX: i2c: Fix build error in debug output code
@ 2018-08-10 18:52 Andrey Smirnov
  2018-08-13  6:42 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Andrey Smirnov @ 2018-08-10 18:52 UTC (permalink / raw)
  To: barebox; +Cc: Andrey Smirnov

Looks like that particular chunk of the code have not been built in a
while and bitrotted. Change function parameters appropriately to avoid
breaking the build.

Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
 drivers/i2c/busses/i2c-imx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
index 4ff4f5c2a..67937da73 100644
--- a/drivers/i2c/busses/i2c-imx.c
+++ b/drivers/i2c/busses/i2c-imx.c
@@ -200,13 +200,13 @@ static void i2c_fsl_dump_reg(struct i2c_adapter *adapter)
 	reg_cr = fsl_i2c_read_reg(i2c_fsl, FSL_I2C_I2CR);
 	reg_sr = fsl_i2c_read_reg(i2c_fsl, FSL_I2C_I2SR);
 
-	dev_dbg(adapter->dev, "CONTROL:\t"
+	dev_dbg(&adapter->dev, "CONTROL:\t"
 		"IEN =%d, IIEN=%d, MSTA=%d, MTX =%d, TXAK=%d, RSTA=%d\n",
 		(reg_cr & I2CR_IEN  ? 1 : 0), (reg_cr & I2CR_IIEN ? 1 : 0),
 		(reg_cr & I2CR_MSTA ? 1 : 0), (reg_cr & I2CR_MTX  ? 1 : 0),
 		(reg_cr & I2CR_TXAK ? 1 : 0), (reg_cr & I2CR_RSTA ? 1 : 0));
 
-	dev_dbg(adapter->dev, "STATUS:\t"
+	dev_dbg(&adapter->dev, "STATUS:\t"
 		"ICF =%d, IAAS=%d, IB  =%d, IAL =%d, SRW =%d, IIF =%d, RXAK=%d\n",
 		(reg_sr & I2SR_ICF  ? 1 : 0), (reg_sr & I2SR_IAAS ? 1 : 0),
 		(reg_sr & I2SR_IBB  ? 1 : 0), (reg_sr & I2SR_IAL  ? 1 : 0),
-- 
2.17.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] i.MX: i2c: Fix build error in debug output code
  2018-08-10 18:52 [PATCH] i.MX: i2c: Fix build error in debug output code Andrey Smirnov
@ 2018-08-13  6:42 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2018-08-13  6:42 UTC (permalink / raw)
  To: Andrey Smirnov; +Cc: barebox

On Fri, Aug 10, 2018 at 11:52:55AM -0700, Andrey Smirnov wrote:
> Looks like that particular chunk of the code have not been built in a
> while and bitrotted. Change function parameters appropriately to avoid
> breaking the build.
> 
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---

Applied, thanks

Sascha

>  drivers/i2c/busses/i2c-imx.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
> index 4ff4f5c2a..67937da73 100644
> --- a/drivers/i2c/busses/i2c-imx.c
> +++ b/drivers/i2c/busses/i2c-imx.c
> @@ -200,13 +200,13 @@ static void i2c_fsl_dump_reg(struct i2c_adapter *adapter)
>  	reg_cr = fsl_i2c_read_reg(i2c_fsl, FSL_I2C_I2CR);
>  	reg_sr = fsl_i2c_read_reg(i2c_fsl, FSL_I2C_I2SR);
>  
> -	dev_dbg(adapter->dev, "CONTROL:\t"
> +	dev_dbg(&adapter->dev, "CONTROL:\t"
>  		"IEN =%d, IIEN=%d, MSTA=%d, MTX =%d, TXAK=%d, RSTA=%d\n",
>  		(reg_cr & I2CR_IEN  ? 1 : 0), (reg_cr & I2CR_IIEN ? 1 : 0),
>  		(reg_cr & I2CR_MSTA ? 1 : 0), (reg_cr & I2CR_MTX  ? 1 : 0),
>  		(reg_cr & I2CR_TXAK ? 1 : 0), (reg_cr & I2CR_RSTA ? 1 : 0));
>  
> -	dev_dbg(adapter->dev, "STATUS:\t"
> +	dev_dbg(&adapter->dev, "STATUS:\t"
>  		"ICF =%d, IAAS=%d, IB  =%d, IAL =%d, SRW =%d, IIF =%d, RXAK=%d\n",
>  		(reg_sr & I2SR_ICF  ? 1 : 0), (reg_sr & I2SR_IAAS ? 1 : 0),
>  		(reg_sr & I2SR_IBB  ? 1 : 0), (reg_sr & I2SR_IAL  ? 1 : 0),
> -- 
> 2.17.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-08-13  6:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-10 18:52 [PATCH] i.MX: i2c: Fix build error in debug output code Andrey Smirnov
2018-08-13  6:42 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox