From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: barebox@lists.infradead.org
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>
Subject: [PATCH 09/22] ARM: i.MX: bbu: Detect which platforms need v2 i.MX header
Date: Mon, 20 Aug 2018 23:25:50 -0700 [thread overview]
Message-ID: <20180821062603.17393-10-andrew.smirnov@gmail.com> (raw)
In-Reply-To: <20180821062603.17393-1-andrew.smirnov@gmail.com>
Detect which platforms need header v2 based on current CPU type and
replace all of the code explicitly specifying that.
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
arch/arm/mach-imx/imx-bbu-internal.c | 29 ++++++++++++++++------------
1 file changed, 17 insertions(+), 12 deletions(-)
diff --git a/arch/arm/mach-imx/imx-bbu-internal.c b/arch/arm/mach-imx/imx-bbu-internal.c
index cff4f6802..3ef49a859 100644
--- a/arch/arm/mach-imx/imx-bbu-internal.c
+++ b/arch/arm/mach-imx/imx-bbu-internal.c
@@ -29,6 +29,7 @@
#include <ioctl.h>
#include <environment.h>
#include <mach/bbu.h>
+#include <mach/generic.h>
#define FLASH_HEADER_OFFSET_MMC 0x400
@@ -332,6 +333,18 @@ out:
return ret;
}
+static enum filetype imx_bbu_expected_filetype(void)
+{
+ if (cpu_is_mx8mq() ||
+ cpu_is_mx7() ||
+ cpu_is_mx6() ||
+ cpu_is_vf610() ||
+ cpu_is_mx53())
+ return filetype_imx_image_v2;
+
+ return filetype_unknown;
+}
+
static int imx_bbu_update(struct bbu_handler *handler, struct bbu_data *data)
{
struct imx_internal_bbu_handler *imx_handler =
@@ -406,7 +419,7 @@ static struct imx_internal_bbu_handler *__init_handler(const char *name,
handler->flags = flags;
handler->handler = imx_bbu_update;
- imx_handler->expected_type = filetype_unknown;
+ imx_handler->expected_type = imx_bbu_expected_filetype();
imx_handler->write_device = __imx_bbu_write_device;
return imx_handler;
@@ -425,8 +438,7 @@ static int __register_handler(struct imx_internal_bbu_handler *imx_handler)
static int
imx_bbu_internal_mmc_register_handler(const char *name, const char *devicefile,
- unsigned long flags,
- enum filetype expected_type)
+ unsigned long flags)
{
struct imx_internal_bbu_handler *imx_handler;
@@ -434,8 +446,6 @@ imx_bbu_internal_mmc_register_handler(const char *name, const char *devicefile,
IMX_BBU_FLAG_KEEP_HEAD);
imx_handler->flash_header_offset = FLASH_HEADER_OFFSET_MMC;
- imx_handler->expected_type = expected_type;
-
return __register_handler(imx_handler);
}
@@ -459,8 +469,7 @@ int imx51_bbu_internal_mmc_register_handler(const char *name,
unsigned long flags)
{
- return imx_bbu_internal_mmc_register_handler(name, devicefile, flags,
- filetype_unknown);
+ return imx_bbu_internal_mmc_register_handler(name, devicefile, flags);
}
/*
@@ -470,8 +479,7 @@ int imx53_bbu_internal_mmc_register_handler(const char *name,
const char *devicefile,
unsigned long flags)
{
- return imx_bbu_internal_mmc_register_handler(name, devicefile, flags,
- filetype_imx_image_v2);
+ return imx_bbu_internal_mmc_register_handler(name, devicefile, flags);
}
/*
@@ -489,8 +497,6 @@ int imx53_bbu_internal_spi_i2c_register_handler(const char *name,
IMX_INTERNAL_FLAG_ERASE);
imx_handler->flash_header_offset = FLASH_HEADER_OFFSET_MMC;
- imx_handler->expected_type = filetype_imx_image_v2;
-
return __register_handler(imx_handler);
}
@@ -505,7 +511,6 @@ int imx53_bbu_internal_nand_register_handler(const char *name,
imx_handler = __init_handler(name, "/dev/nand0", flags);
imx_handler->flash_header_offset = FLASH_HEADER_OFFSET_MMC;
- imx_handler->expected_type = filetype_imx_image_v2;
imx_handler->device_size = partition_size;
imx_handler->write_device = imx_bbu_internal_v2_write_nand_dbbt;
--
2.17.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2018-08-21 6:26 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-21 6:25 [PATCH 00/22] i.MX BBU improvements and bugfixes Andrey Smirnov
2018-08-21 6:25 ` [PATCH 01/22] ARM: i.MX: bbu: Remove unused define Andrey Smirnov
2018-08-21 6:25 ` [PATCH 02/22] filetype: Add code to detect i.MX image v1 Andrey Smirnov
2018-08-21 10:07 ` Roland Hieber
2018-08-21 20:23 ` Andrey Smirnov
2018-08-23 9:33 ` Roland Hieber
2018-08-23 21:01 ` Andrey Smirnov
2018-08-21 6:25 ` [PATCH 03/22] filetype: Add code to detect i.MX image v2 Andrey Smirnov
2018-08-21 6:25 ` [PATCH 04/22] ARM: i.MX: bbu: Move inner-image type check Andrey Smirnov
2018-08-22 6:49 ` Sascha Hauer
2018-08-22 6:52 ` Sascha Hauer
2018-08-23 0:06 ` Andrey Smirnov
2018-08-23 6:44 ` Sascha Hauer
2018-08-21 6:25 ` [PATCH 05/22] ARM: i.MX: bbu: Drop IMX_INTERNAL_FLAG_NAND Andrey Smirnov
2018-08-21 6:25 ` [PATCH 06/22] ARM: i.MX: bbu: Consolidate vairous update helpers Andrey Smirnov
2018-08-22 6:52 ` Sascha Hauer
2018-08-23 0:07 ` Andrey Smirnov
2018-08-21 6:25 ` [PATCH 07/22] ARM: i.MX: bbu: Simplify imx53_bbu_internal_nand_register_handler() Andrey Smirnov
2018-08-21 6:25 ` [PATCH 08/22] ARM: i.MX: bbu: Constify all 'devicefile' arguments Andrey Smirnov
2018-08-21 6:25 ` Andrey Smirnov [this message]
2018-08-21 6:25 ` [PATCH 10/22] ARM: i.MX: bbu: Alias imx5*_bbu_internal_mmc_register_handler() Andrey Smirnov
2018-08-21 6:25 ` [PATCH 11/22] ARM: i.MX: bbu: Alias imx5*_bbu_internal_spi_i2c_register_handler() Andrey Smirnov
2018-08-21 6:25 ` [PATCH 12/22] ARM: i.MX: bbu: Move protect code into a separate routine Andrey Smirnov
2018-08-21 6:25 ` [PATCH 13/22] ARM: i.MX: bbu: Adjust FLASH_HEADER_OFFSET_MMC for i.MX8MQ Andrey Smirnov
2018-08-21 6:25 ` [PATCH 14/22] ARM: i.MX: bbu: Add support for SPI/I2C on VFxxx Andrey Smirnov
2018-08-21 6:25 ` [PATCH 15/22] ARM: i.MX: zii-vf610-dev-rev-b/c: Add support for BBU on SPI-NOR Andrey Smirnov
2018-08-21 6:25 ` [PATCH 16/22] ARM: i.MX: bbu: Add support for MMC on i.MX8MQ Andrey Smirnov
2018-08-21 6:25 ` [PATCH 17/22] ARM: nxp-imx8mq-evk: Add eMMC BBU configuration Andrey Smirnov
2018-08-21 6:25 ` [PATCH 18/22] ARM: i.MX: bbu: Adjust error code check for pwrite() Andrey Smirnov
2018-08-22 7:01 ` Sascha Hauer
2018-08-23 0:16 ` Andrey Smirnov
2018-08-21 6:26 ` [PATCH 19/22] bbu: Remove logical negation in barebox_update_handler_exists() Andrey Smirnov
2018-08-22 7:09 ` Sascha Hauer
2018-08-23 0:01 ` Andrey Smirnov
2018-08-23 4:43 ` Sam Ravnborg
2018-08-23 6:42 ` Sascha Hauer
2018-08-23 6:48 ` Andrey Smirnov
2018-08-21 6:26 ` [PATCH 20/22] block: Do not ignore error in blk->ops->write() Andrey Smirnov
2018-08-21 6:26 ` [PATCH 21/22] bbu: Report update failures explicitly Andrey Smirnov
2018-08-21 6:26 ` [PATCH 22/22] bbu: command: Make sure specified update handler exists Andrey Smirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180821062603.17393-10-andrew.smirnov@gmail.com \
--to=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox