mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Aleksander Morgado <aleksander@aleksander.es>
To: barebox@lists.infradead.org, s.hauer@pengutronix.de
Cc: Aleksander Morgado <aleksander@aleksander.es>
Subject: [PATCH 2/2] i2c_read: implement support for master receive mode
Date: Tue, 21 Aug 2018 17:18:26 +0200	[thread overview]
Message-ID: <20180821151826.5011-3-aleksander@aleksander.es> (raw)
In-Reply-To: <20180821151826.5011-1-aleksander@aleksander.es>

If no start register is explicitly given, receive data in master
receive mode.

Signed-off-by: Aleksander Morgado <aleksander@aleksander.es>
---
 commands/i2c.c | 21 +++++++++++++++------
 1 file changed, 15 insertions(+), 6 deletions(-)

diff --git a/commands/i2c.c b/commands/i2c.c
index 57dc092c2..2f7f820d4 100644
--- a/commands/i2c.c
+++ b/commands/i2c.c
@@ -208,7 +208,7 @@ static int do_i2c_read(int argc, char *argv[])
 		}
 	}
 
-	if ((addr < 0) || (reg < 0) || (count < 1) || (addr > 0x7F))
+	if ((addr < 0) || (count < 1) || (addr > 0x7F))
 		return COMMAND_ERROR_USAGE;
 
 	adapter = i2c_get_adapter(bus);
@@ -221,12 +221,21 @@ static int do_i2c_read(int argc, char *argv[])
 	client.addr = addr;
 
 	buf = xmalloc(count);
-	ret = i2c_read_reg(&client, reg | wide, buf, count);
+	if (reg >= 0)
+		ret = i2c_read_reg(&client, reg | wide, buf, count);
+	else
+		ret = i2c_master_recv(&client, buf, count);
 	if (ret == count) {
 		int i;
-		if (verbose)
-			printf("read %i bytes starting at reg 0x%04x from i2cdev 0x%02x on bus %i\n",
-				count, reg, addr, adapter->nr);
+		if (verbose) {
+			if (reg >= 0)
+				printf("read %i bytes starting at reg 0x%04x from i2cdev 0x%02x on bus %i\n",
+				       count, reg, addr, adapter->nr);
+			else
+				printf("received %i bytes in master receive mode from i2cdev 0x%02x on bus %i\n",
+				       count, addr, adapter->nr);
+		}
+
 		for (i = 0; i < count; i++)
 			printf("0x%02x ", *(buf + i));
 		printf("\n");
@@ -241,7 +250,7 @@ BAREBOX_CMD_HELP_START(i2c_read)
 BAREBOX_CMD_HELP_TEXT("Options:")
 BAREBOX_CMD_HELP_OPT("-b BUS\t", "i2c bus number (default 0)")
 BAREBOX_CMD_HELP_OPT("-a ADDR\t", "i2c device address")
-BAREBOX_CMD_HELP_OPT("-r START", "start register")
+BAREBOX_CMD_HELP_OPT("-r START", "start register (optional, master receive mode if none given)")
 BAREBOX_CMD_HELP_OPT("-w\t",       "use word (16 bit) wide access")
 BAREBOX_CMD_HELP_OPT("-c COUNT", "byte count")
 BAREBOX_CMD_HELP_OPT("-v\t",       "verbose")
-- 
2.18.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2018-08-21 15:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-21 15:18 i2c master send/receive mode Aleksander Morgado
2018-08-21 15:18 ` [PATCH 1/2] i2c_write: document master send mode Aleksander Morgado
2018-08-21 15:18 ` Aleksander Morgado [this message]
2018-08-22  7:37 ` i2c master send/receive mode Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180821151826.5011-3-aleksander@aleksander.es \
    --to=aleksander@aleksander.es \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox